Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2643753002: Add the suggestions UI in chrome (Closed)
Patch Set: Move to content suggestions Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index 2cc3d7b1a3e1efc3f37c274ad7b10aeb8ddccbf7..6deaf9c97ac72aeec0ae2ae33940eedb3d222465 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -50,6 +50,7 @@
#include "ios/chrome/browser/browser_state/chrome_browser_state.h"
#include "ios/chrome/browser/chrome_url_constants.h"
#include "ios/chrome/browser/chrome_url_util.h"
+#import "ios/chrome/browser/content_suggestions/content_suggestions_coordinator.h"
#include "ios/chrome/browser/experimental_flags.h"
#import "ios/chrome/browser/favicon/favicon_loader.h"
#include "ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.h"
@@ -384,6 +385,10 @@ NSString* const kNativeControllerTemporaryKey = @"NativeControllerTemporaryKey";
// Used to display the QR Scanner UI. Nil if not visible.
base::scoped_nsobject<QRScannerViewController> _qrScannerViewController;
+ // Used to display the Suggestions.
+ base::scoped_nsobject<ContentSuggestionsCoordinator>
+ _contentSuggestionsCoordinator;
+
// Used to display the Find In Page UI. Nil if not visible.
base::scoped_nsobject<FindBarControllerIOS> _findBarController;
@@ -4105,6 +4110,11 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
[self showQRScanner];
}
break;
+ case IDC_SHOW_SUGGESTIONS:
+ if (experimental_flags::IsSuggestionsUIEnabled()) {
+ [self showSuggestionsUI];
+ }
+ break;
default:
// Unknown commands get sent up the responder chain.
[super chromeExecuteCommand:sender];
@@ -4210,6 +4220,8 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
[_contextMenuCoordinator stop];
[self dismissRateThisAppDialog];
+ [_contentSuggestionsCoordinator stop];
+
if (self.presentedViewController) {
// Dismisses any other modal controllers that may be present, e.g. Recent
// Tabs.
@@ -4369,6 +4381,14 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
completion:nil];
}
+- (void)showSuggestionsUI {
+ if (!_contentSuggestionsCoordinator) {
+ _contentSuggestionsCoordinator.reset([[ContentSuggestionsCoordinator alloc]
+ initWithBaseViewController:self]);
+ }
+ [_contentSuggestionsCoordinator start];
+}
+
- (void)showNTPPanel:(NewTabPage::PanelIdentifier)panel {
DCHECK(self.visible || self.dismissingModal);
GURL url(kChromeUINewTabURL);

Powered by Google App Engine
This is Rietveld 408576698