Add the suggestions UI in chrome

ios/chrome/browser/ui/browser_view_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/browser_view_controller.h"
 
 #import <AssetsLibrary/AssetsLibrary.h>
 #import <MobileCoreServices/MobileCoreServices.h>
 #import <PassKit/PassKit.h>
 #import <Photos/Photos.h>
@@ skipping 57 matching lines @@
 #include "ios/chrome/browser/pref_names.h"
 #include "ios/chrome/browser/reading_list/reading_list_model_factory.h"
 #include "ios/chrome/browser/search_engines/template_url_service_factory.h"
 #include "ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.h"
 #include "ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.h"
 #include "ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios_factory.h"
 #import "ios/chrome/browser/snapshots/snapshot_cache.h"
 #import "ios/chrome/browser/snapshots/snapshot_overlay.h"
 #import "ios/chrome/browser/snapshots/snapshot_overlay_provider.h"
 #import "ios/chrome/browser/storekit_launcher.h"
+#import "ios/chrome/browser/suggestions/suggestions_coordinator.h"
 #import "ios/chrome/browser/tabs/tab.h"
 #import "ios/chrome/browser/tabs/tab_dialog_delegate.h"
 #import "ios/chrome/browser/tabs/tab_headers_delegate.h"
 #import "ios/chrome/browser/tabs/tab_model.h"
 #import "ios/chrome/browser/tabs/tab_model_observer.h"
 #import "ios/chrome/browser/tabs/tab_snapshotting_delegate.h"
 #import "ios/chrome/browser/ui/activity_services/share_protocol.h"
 #import "ios/chrome/browser/ui/activity_services/share_to_data.h"
 #import "ios/chrome/browser/ui/alert_coordinator/alert_coordinator.h"
 #import "ios/chrome/browser/ui/authentication/re_signin_infobar_delegate.h"
@@ skipping 292 matching lines @@
 
   // Used to display the Page Info UI.  Nil if not visible.
   base::scoped_nsobject<PageInfoViewController> _pageInfoController;
 
   // Used to display the Voice Search UI.  Nil if not visible.
   scoped_refptr<VoiceSearchController> _voiceSearchController;
 
   // Used to display the QR Scanner UI. Nil if not visible.
   base::scoped_nsobject<QRScannerViewController> _qrScannerViewController;
 
+  // Used to display the Suggestions.
+  base::scoped_nsobject<SuggestionsCoordinator> _suggestionsCoordinator;
+
   // Used to display the Find In Page UI. Nil if not visible.
   base::scoped_nsobject<FindBarControllerIOS> _findBarController;
 
   // Used to display the No-Tabs UI for iPads.  Nil if not visible.
   base::scoped_nsobject<NoTabsController> _noTabsController;
 
   // Used to display the Print UI. Nil if not visible.
   base::scoped_nsobject<PrintController> _printController;
 
   // Records the set of domains for which full screen alert has already been
@@ skipping 3694 matching lines @@
       // before sending the command up the responder chain.
       if ([sender isKindOfClass:[UIView class]])
         _voiceSearchButton.reset(sender);
       [super chromeExecuteCommand:sender];
       break;
     case IDC_SHOW_QR_SCANNER:
       if (experimental_flags::IsQRCodeReaderEnabled()) {
         [self showQRScanner];
       }
       break;
+    case IDC_SHOW_SUGGESTIONS_UI:
+      if (experimental_flags::IsSuggestionsUIEnabled()) {
+        [self showSuggestionsUI];
+      }
+      break;
     default:
       // Unknown commands get sent up the responder chain.
       [super chromeExecuteCommand:sender];
       break;
   }
 }
 
 - (void)closeCurrentTab {
   Tab* currentTab = [_model currentTab];
   NSUInteger tabIndex = [_model indexOfTab:currentTab];
@@ skipping 58 matching lines @@
   CGRect fromRect = [_toolbarController shareButtonAnchorRect];
   UIView* inView = [_toolbarController shareButtonView];
   [controller shareWithData:data
                  controller:self
                browserState:_browserState
             shareToDelegate:self
                    fromRect:fromRect
                      inView:inView];
 }
 
 - (void)clearPresentedStateWithCompletion:(ProceduralBlock)completion {

[lpromero, 2017/01/18 13:32:15]

You probably need to add a call to stop there (or simply reset the coordinator).

[gambard, 2017/01/18 14:34:47]

Done.

   [[_dependencyFactory shareControllerInstance] cancelShareAnimated:NO];
   [_bookmarkInteractionController dismissBookmarkModalControllerAnimated:NO];
   [_bookmarkInteractionController dismissSnackbar];
   [_toolbarController cancelOmniboxEdit];
   [_dialogPresenter cancelAllDialogs];
   [self hidePageInfoPopupForView:nil];
   if (_voiceSearchController)
     _voiceSearchController->DismissMicPermissionsHelp();
   [[_model currentTab] dismissModals];
   [[_model currentTab].findInPageController
@@ skipping 165 matching lines @@
 
 - (void)showQRScanner {
   _qrScannerViewController.reset(
       [[QRScannerViewController alloc] initWithDelegate:_toolbarController]);
   [self presentViewController:[_qrScannerViewController
                                   getViewControllerToPresent]
                      animated:YES
                    completion:nil];
 }
 
+- (void)showSuggestionsUI {

[lpromero, 2017/01/18 13:32:15]

This could be called twice in a row (for example when the UI is lagging and the
user taps twice, thinking the first one didn't get called). In that case, we
seem to call -start twice, no?

[gambard, 2017/01/18 14:34:47]

Fixed in the coordinator.

+  if (!_suggestionsCoordinator) {
+    _suggestionsCoordinator.reset(
+        [[SuggestionsCoordinator alloc] initWithBaseViewController:self]);
+  }
+  [_suggestionsCoordinator start];
+}
+
 - (void)showNTPPanel:(NewTabPage::PanelIdentifier)panel {
   DCHECK(self.visible || self.dismissingModal);
   GURL url(kChromeUINewTabURL);
   std::string fragment(NewTabPage::FragmentFromIdentifier(panel));
   if (fragment != "") {
     GURL::Replacements replacement;
     replacement.SetRefStr(fragment);
     url = url.ReplaceComponents(replacement);
   }
   Tab* tab = [_model currentTab];
@@ skipping 763 matching lines @@
 
 - (UIView*)voiceSearchButton {
   return _voiceSearchButton;
 }
 
 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner {
   return [self currentLogoAnimationControllerOwner];
 }
 
 @end