Issue 264373005: New test cases for the display-grid-set-get.html test.

Issue 264373005: New test cases for the display-grid-set-get.html test. (Closed)

Created:
6 years, 7 months ago by jfernandez

Modified:
6 years, 7 months ago

Reviewers:
Julien - ping for review, eseidel, ojan

CC:
blink-reviews, svillar, jfernandez, Manuel Rego

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

New test cases for the display-grid-set-get.html test. If an element’s specified display is inline-grid and the element is floated or absolutely positioned, the computed value of display is grid. BUG=79180 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174600

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -0 lines)			Patch
M	LayoutTests/fast/css-grid-layout/display-grid-set-get.html	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/css-grid-layout/resources/display-grid-set-get.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Julien - ping for review

LGTM, let's add what new test you're adding to the description before landing.

6 years, 7 months ago (2014-05-21 16:13:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfernandez@igalia.com/264373005/1

6 years, 7 months ago (2014-05-22 14:45:04 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...

6 years, 7 months ago (2014-05-22 20:46:03 UTC) #6

Message was sent while issue was closed.

Change committed as 174600

Expand Messages | Collapse Messages