Issue 264373004: Return has value, in function returning void.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264373004: Return has value, in function returning void. (Closed)

Created:
6 years, 7 months ago by dshwang

Modified:
6 years, 7 months ago

Reviewers:
piman

CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Return has value, in function returning void. BUG=N/A Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269363

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -7 lines)			Patch
M	content/browser/compositor/delegated_frame_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gl/gl_gl_api_implementation.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/264373004/1

6 years, 7 months ago (2014-05-08 18:34:18 UTC) #4

Message was sent while issue was closed.

Change committed as 269363

Expand Messages | Collapse Messages