ios/chrome/browser/desktop_promotion/BUILD.gn - Issue 2643723004: Add Desktop iOS promotion logging to chrome ios app.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/desktop_promotion/BUILD.gn

Issue 2643723004: Add Desktop iOS promotion logging to chrome ios app. (Closed)

Patch Set: change histogram name Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("desktop_promotion") {

	6 sources = [

	7 "desktop_promotion_sync_observer.h",

	8 "desktop_promotion_sync_observer.mm",

	9 "desktop_promotion_sync_service.cc",

	10 "desktop_promotion_sync_service.h",

	11 "desktop_promotion_sync_service_factory.cc",

	12 "desktop_promotion_sync_service_factory.h",

	13 ]

	14 deps = [

	15 "//base",

	16 "//components/browser_sync",

	17 "//components/keyed_service/ios",

	18 "//components/metrics",

	19 "//components/pref_registry",

	20 "//components/prefs",

	21 "//ios/chrome/browser",

	22 "//ios/chrome/browser/browser_state",

	23 "//ios/chrome/browser/sync/",
	sdefresne 2017/01/30 15:47:19 Remove trailing "/" :-) Remove trailing "/" :-) mrefaat 2017/01/30 16:32:23 Acknowledged. Show quoted text On 2017/01/30 15:47:19, sdefresne wrote: > Remove trailing "/" :-) Acknowledged.
	24 "//ios/chrome/common",

	25 ]

	26 }

OLD	NEW