tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index eef0a376034b7a9d51553b265a49c94b159950ff..a16808a9635f6f8660f0497e65fc3dba6c9ebd73 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -10071,6 +10071,32 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="DesktopIOSPromotion.CompletionTime" units="hours">

[Mark P, 2017/01/27 20:07:33]

Please consider putting SMS in the histogram name somewhere.  Otherwise the fact
that this is only logged for SMSs is easily missed.

(When renaming, remember to rename places in the code that emits to this
histogram too.)

[mrefaat, 2017/01/28 00:02:24]

Acknowledged.

+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    [IOS] The difference between the client time of triggering the SMS action on
+    a specific entry point promotion on desktop and client time of signing in
+    Chrome iOS app. This will only be logged if at least one promotion was shown

[Mark P, 2017/01/27 20:07:33]

nit:
at least one promotion was shown
->
at least one promotion sent an SMS

[mrefaat, 2017/01/28 00:02:24]

That's not true it's if at least one promotion is shown but this will not be
logged if no sms was sent so i'll change it to mention both.

+    to the user on the last 7 days. If the value is negative due to bad clock on

[Mark P, 2017/01/27 20:07:34]

Before the "If the value is negative" sentence, please add
If multiple SMSs were sent, it uses the time of the most recently sent one.

[mrefaat, 2017/01/28 00:02:24]

Done.

+    one of the clients it will be logged as 0. CompletionTime will be prefixed
+    by the entry point promotion name that was responsible for the SMS sending.
+  </summary>
+</histogram>
+
+<histogram name="DesktopIOSPromotion.IOSSigninReason"
+    enum="DesktopIOSPromotionEntryPoint">
+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    [IOS] For users who sign-in on Chrome for iOS, log the type of the desktop
+    iOS promotions that was shown to the user. Only recorded if the user has
+    seen at least one desktop iOS promotion in the last 7 days and is signing
+    into chrome on iOS. The last promotion entry point that sent an SMS (if any)
+    is logged as DesktopIOSPromot.SMSSent.IOSSigninReason; all other promotions
+    that the user has seen are logged as
+    DesktopIOSPromotion.NoSMS.IOSSigninReason.
+  </summary>
+</histogram>
+
 <histogram name="DevTools.ActionTaken" enum="DevToolsAction">
   <owner>sergeyv@chromium.org</owner>
   <owner>vsevik@chromium.org</owner>
@@ -83526,6 +83552,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="12" label="Tab capturer created without audio capturer."/>
 </enum>
 
+<enum name="DesktopIOSPromotionEntryPoint" type="int">
+  <int value="1" label="Save Passwords new bubble."/>
+  <int value="2" label="Bookmarks new bubble."/>
+  <int value="3" label="Bookmarks existing bubble."/>
+  <int value="4" label="HistoryPage."/>
+</enum>
+
 <enum name="DesktopSearchRedirectionInfobarCloseAction" type="int">
   <int value="0" label="Clicked the 'Manage search settings' link"/>
   <int value="1" label="Clicked the dismiss button"/>
@@ -112247,6 +112280,22 @@ value.
       name="Prerender.SimulatedLocalBrowsingPLT_PrerenderNoUse"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="DesktopIOSEntryPoints" separator="."
+    ordering="prefix">
+  <suffix name="SavePasswordsNewBubble"/>
+  <suffix name="BookmarksNewBubble"/>
+  <suffix name="BookmarksExistingBubble"/>
+  <suffix name="HistoryPage"/>
+  <affected-histogram name="DesktopIOSPromotion.CompletionTime"/>
+</histogram_suffixes>
+
+<histogram_suffixes name="DesktopIOSPromotionSMSSent" separator="."
+    ordering="prefix">
+  <suffix name="SMSSent" label="SMS sent from the promotion."/>
+  <suffix name="NoSMS" label="No SMS was sent from the promotion."/>
+  <affected-histogram name="DesktopIOSPromotion.IOSSigninReason"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="DiskUsagePerUserCount" separator=".">
   <suffix name="1User" label="Only 1 user exists on device."/>
   <suffix name="2Users" label="2 users exist on device."/>