tools/metrics/histograms/histograms.xml - Issue 2643723004: Add Desktop iOS promotion logging to chrome ios app.

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2643723004: Add Desktop iOS promotion logging to chrome ios app. (Closed)

Patch Set: remove histogram_macros Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index eef0a376034b7a9d51553b265a49c94b159950ff..094c2a0fe1f11d5d8aeaddb7efba3906edb31e62 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -10071,6 +10071,31 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="DesktopIOSPromotion.CompletionTime" units="hours">

+ <owner>mrefaat@chromium.org</owner>

+ <summary>

+ [IOS] Time between when the client time of triggering the SMS action on a

+ specific entry point promotion on desktop and client time of signing in

+ Chrome iOS app, if the value is negative due to bad clock on one of the

Mark P 2017/01/27 18:58:59 nit: , -> ; (or period and start a new sentence b

mrefaat 2017/01/27 19:58:41 Done.

+ clients it will be logged as 0. CompletionTime will be prefixed by the entry

+ point promotion name that was responsible for the SMS sending.

+ </summary>

+</histogram>

+<histogram name="DesktopIOSPromotion.IOSSigninReason"

+ enum="DesktopIOSPromotionEntryPoint">

+ <owner>mrefaat@chromium.org</owner>

+ <summary>

+ [IOS] For users who sign-in on Chrome for iOS, log the type of the desktop

+ iOS promotions that was shown to the user. This will only be logged if at

+ least one promotion was shown to this user on the last 7 days IOSigninReason

Mark P 2017/01/27 18:58:59 period after "days". You're starting a new senten

mrefaat 2017/01/27 19:58:41 Done.

+ will be prefixed to indicate if there was SMS sent from the promotion or

+ not. DesktopIOSPromotion.SMSSent.IOSSigninReason will be logged at most once

+ per each user, as once the user have recieved and sms and completed the

+ cycle they will not see any other desktop to iOS promotion again.

Mark P 2017/01/27 18:58:59 It sounds like you're saying you only log the SMS

It sounds like you're saying you only log the SMS sent form if the user entered Chrome due to the SMS. That's why it gets logged only once. If the user sent an SMS and launched Chrome on iOS without having viewed the SMS, then it doesn't get logged. Correct? If so, I suggest revising the last two sentence (well, two sentence after you add the period I asked for) as follows: IOSigninReason will be prefixed to indicate if the user launched Chrome and signed in due to using an SMS sent from a promotion. Hence, DesktopIOSPromotion.SMSSent.IOSSigninReason will be logged at most once. If a user sends an SMS from one or more promotions and doesn't use the SMS to help sign-in to Chrome, all of these will be recorded as NoSMS.

mrefaat 2017/01/27 19:58:41 The user doesn't need to launch chrome by clicking

On 2017/01/27 18:58:59, Mark P wrote: > On 2017/01/27 18:29:42, mrefaat wrote: > > On 2017/01/26 23:47:24, Mark P wrote: > > > On 2017/01/26 23:34:12, mrefaat wrote: > > > > On 2017/01/26 18:55:15, Mark P wrote: > > > > > This last part of the description doesn't sound right. It looks to me > > like > > > > you > > > > > only emit one SMSSent entry, regardless of whether the user sent SMS > from > > > > > multiple promotions. > > > > > > > > > > if (sms_entrypoint == i) { > > > > > ... > > > > > } > > > > I'll try to explain more. > > > > > > This last part doesn't make sense to me. It says that once the user has > > > received an sms and completed a cycle, that's what stops desktop promotions. > > > > Yet I can easily imagine sending an SMS and not doing anything on the iOS > > device > > > (not even turning it on), then seeing another desktop promotion, sending > > another > > > SMS. The last part of the sentence implies this is possible, which > > contradicts > > > the first part of the sentence saying at most only one SMS would be sent. > > What > > > am I missing? > > > > It will be logged at most once because you have to get into the iOS client to > > actual log, so assuming that we target the user with the promotion and they > > actually clicked the send sms button and didn't open chrome on their iOS > device > > no thing will be logged as we only log when we have the user signed in in the > > client, then the user is targeted by different promotion or they clear their > own > > local prefs - they may see it again but still nothing will be logged as we > only > > log when they open chrome on ios and signin. > > It sounds like you're saying you only log the SMS sent form if the user entered > Chrome due to the SMS. That's why it gets logged only once. If the user sent > an SMS and launched Chrome on iOS without having viewed the SMS, then it doesn't > get logged. Correct? > > If so, I suggest revising the last two sentence (well, two sentence after you > add the period I asked for) as follows: > IOSigninReason will be prefixed to indicate if the user launched Chrome and > signed in due to using an SMS sent from a promotion. Hence, > DesktopIOSPromotion.SMSSent.IOSSigninReason will be logged at most once. If a > user sends an SMS from one or more promotions and doesn't use the SMS to help > sign-in to Chrome, all of these will be recorded as NoSMS.

The user doesn't need to launch chrome by clicking on the SMS, actually the SMS will direct the user to the app store so they can install chrome. But if the user got SMS saw a promotion on last 7 days and signed in to chrome we say that the reason is SMSSent.

+ </summary>

+</histogram>

<owner>sergeyv@chromium.org</owner>

<owner>vsevik@chromium.org</owner>

@@ -83526,6 +83551,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</enum>

+<enum name="DesktopIOSPromotionEntryPoint" type="int">

+ <int value="1" label="Save Passwords new bubble."/>

+ <int value="2" label="Bookmarks new bubble."/>

+ <int value="3" label="Bookmarks existing bubble."/>

+ <int value="4" label="HistoryPage."/>

+</enum>

@@ -112247,6 +112279,22 @@ value.

name="Prerender.SimulatedLocalBrowsingPLT_PrerenderNoUse"/>

</histogram_suffixes>

+<histogram_suffixes name="DesktopIOSEntryPoints" separator="."

+ ordering="prefix">

+ <suffix name="SavePasswordsNewBubble"/>

+ <suffix name="BookmarksNewBubble"/>

+ <suffix name="BookmarksExistingBubble"/>

+ <suffix name="HistoryPage"/>

+ <affected-histogram name="DesktopIOSPromotion.CompletionTime"/>

+</histogram_suffixes>

+<histogram_suffixes name="DesktopIOSPromotionSMSSent" separator="."

+ ordering="prefix">

+ <suffix name="SMSSent" label="SMS sent from the promotion."/>

+ <suffix name="NoSMS" label="No SMS was sent from the promotion."/>

+ <affected-histogram name="DesktopIOSPromotion.IOSSigninReason"/>

+</histogram_suffixes>

<histogram_suffixes name="DiskUsagePerUserCount" separator=".">

« ios/chrome/browser/desktop_promotion/desktop_promotion_sync_observer.mm ('K') | « ios/chrome/browser/prefs/browser_prefs.mm ('k') | no next file » | no next file with comments »