tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 5797b34d5f6a464db54343e1e5f82d15fe0ae728..584b2460b576a3789afaaa840f2b58b40f6ac0c1 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -10058,6 +10058,30 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="DesktopIOSPromotion.CompletionTime" units="hours">
+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    [IOS] Time between when the client time of triggering the SMS action on a
+    specific entry point promotion on desktop and client time of signing in
+    Chrome iOS app. CompletionTime will be prefixed by the entry point promotion
+    name that was responsible for the SMS sending.

[Mark P, 2017/01/26 23:47:24]

Please say something about negative times (due to bad user clocks) being emitted
as 0s.

[mrefaat, 2017/01/27 18:29:42]

Done.

+  </summary>
+</histogram>
+
+<histogram name="DesktopIOSPromotion.IOSSigninReason"
+    enum="DesktopIOSPromotionEntryPoint">
+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    [IOS] For users who sign-in on Chrome for iOS, log the type of the desktop
+    iOS promotions that was shown to the user. This will only be logged if at
+    least one promotion was shown to this user on the last 7 days IOSigninReason
+    will be prefixed to indicate if there was SMS sent from the promotion or
+    not. DesktopIOSPromotion.SMSSent.IOSSigninReason will be logged at most once
+    per each user, as once the user have recieved and sms and completed the
+    cycle they will not see any other desktop to iOS promotion again.

[Mark P, 2017/01/26 23:47:24]

This last part doesn't make sense to me.  It says that once the user has
received an sms and completed a cycle, that's what stops desktop promotions. 
Yet I can easily imagine sending an SMS and not doing anything on the iOS device
(not even turning it on), then seeing another desktop promotion, sending another
SMS.  The last part of the sentence implies this is possible, which contradicts
the first part of the sentence saying at most only one SMS would be sent.  What
am I missing?

[mrefaat, 2017/01/27 18:29:42]

It will be logged at most once because you have to get into the iOS client to
actual log, so assuming that we target the user with the promotion and they
actually clicked the send sms button and didn't open chrome on their iOS device
no thing will be logged as we only log when we have the user signed in in the
client, then the user is targeted by different promotion or they clear their own
local prefs - they may see it again but still nothing will be logged as we only
log when they open chrome on ios and signin.

+  </summary>
+</histogram>
+
 <histogram name="DevTools.ActionTaken" enum="DevToolsAction">
   <owner>sergeyv@chromium.org</owner>
   <owner>vsevik@chromium.org</owner>
@@ -83676,6 +83700,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="12" label="Tab capturer created without audio capturer."/>
 </enum>
 
+<enum name="DesktopIOSPromotionEntryPoint" type="int">
+  <int value="1" label="Save Passwords new bubble."/>
+  <int value="2" label="Bookmarks new bubble."/>
+  <int value="3" label="Bookmarks existing bubble."/>
+  <int value="4" label="HistoryPage."/>
+</enum>
+
 <enum name="DesktopSearchRedirectionInfobarCloseAction" type="int">
   <int value="0" label="Clicked the 'Manage search settings' link"/>
   <int value="1" label="Clicked the dismiss button"/>
@@ -112394,6 +112425,22 @@ value.
       name="Prerender.SimulatedLocalBrowsingPLT_PrerenderNoUse"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="DesktopIOSEntryPoints" separator="."
+    ordering="prefix">
+  <suffix name="SavePasswordsNewBubble"/>
+  <suffix name="BookmarksNewBubble"/>
+  <suffix name="BookmarksExistingBubble"/>
+  <suffix name="HistoryPage"/>
+  <affected-histogram name="DesktopIOSPromotion.CompletionTime"/>
+</histogram_suffixes>
+
+<histogram_suffixes name="DesktopIOSPromotionSMSSent" separator="."
+    ordering="prefix">
+  <suffix name="SMSSent" label="SMS sent from the promotion."/>
+  <suffix name="NoSMS" label="No SMS was sent from the promotion."/>
+  <affected-histogram name="DesktopIOSPromotion.IOSSigninReason"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="DiskUsagePerUserCount" separator=".">
   <suffix name="1User" label="Only 1 user exists on device."/>
   <suffix name="2Users" label="2 users exist on device."/>