ios/chrome/browser/desktop_promotion/desktop_promotion_prefs.h - Issue 2643723004: Add Desktop iOS promotion logging to chrome ios app.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/desktop_promotion/desktop_promotion_prefs.h

Issue 2643723004: Add Desktop iOS promotion logging to chrome ios app. (Closed)

Patch Set: browser_state keyed service Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_DESKTOP_PROMOTION_DESKTOP_PROMOTION_PREFS_H

	6 #define CHROME_BROWSER_DESKTOP_PROMOTION_DESKTOP_PROMOTION_PREFS_H

	7

	8 namespace user_prefs {

	9 class PrefRegistrySyncable;

	10 }

	11

	12 namespace prefs {
	sdefresne 2017/01/26 17:03:25 Can you move those prefs to ios/chrome/browser/pre Can you move those prefs to ios/chrome/browser/pref_names.h? All prefs for ios/chrome should be defined there IIUC. mrefaat 2017/01/26 23:34:12 Done. Show quoted text On 2017/01/26 17:03:25, sdefresne wrote: > Can you move those prefs to ios/chrome/browser/pref_names.h? All prefs for > ios/chrome should be defined there IIUC. Done.
	13 extern const char kDesktopIOSPromotionSMSEntryPoint[];

	14 extern const char kDesktopIOSPromotionTargetedEntryPoints[];

	15 extern const char kDesktopIOSPromotionLastImpression[];

	16 extern const char kDesktopIOSPromotionDone[];

	17 } // namespace prefs

	18

	19 // Register profile specific desktop promotion related preferences.

	20 void RegisterDesktopPromotionUserPrefs(

	21 user_prefs::PrefRegistrySyncable* registry);

	22

	23 #endif // CHROME_BROWSER_DESKTOP_PROMOTION_DESKTOP_PROMOTION_PREFS_H

OLD	NEW