Add Desktop iOS promotion logging to chrome ios app.

ios/chrome/browser/desktop_promotion/desktop_promotion_prefs.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_DESKTOP_PROMOTION_DESKTOP_PROMOTION_PREFS_H
+#define CHROME_BROWSER_DESKTOP_PROMOTION_DESKTOP_PROMOTION_PREFS_H
+
+namespace user_prefs {
+class PrefRegistrySyncable;
+}
+
+namespace prefs {
+extern const char kDesktopIOSPromotionSMSEntryPoint[];

[rohitrao (ping after 24h), 2017/01/23 20:31:39]

Could these live with the other prefs in ios/chrome/browser/pref_names.h?

[mrefaat, 2017/01/24 19:57:19]

Is there a benefit of doing that, many of the feature directories have their own
pref files. specially that all my prefs are profile state priority prefs not
local prefs.

+extern const char kDesktopIOSPromotionTargetedEntryPoints[];
+extern const char kDesktopIOSPromotionLastImpression[];
+extern const char kDesktopIOSPromotionDone[];
+}  // namespace prefs
+
+namespace desktop_ios_promotion {

[rohitrao (ping after 24h), 2017/01/23 20:31:39]

I would get rid of the namespace here, because you already have
"DesktopPromotion" in the method name.

[mrefaat, 2017/01/24 19:57:19]

Acknowledged.

+
+// Register profile specific desktop promotion related preferences.
+void RegisterDesktopPromotionUserPrefs(
+    user_prefs::PrefRegistrySyncable* registry);
+
+}  // namespace desktop_ios_promotion
+
+#endif  // CHROME_BROWSER_DESKTOP_PROMOTION_DESKTOP_PROMOTION_PREFS_H