tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 986307c805e38b81a2605d01fb82ea44a6471701..6574ea336ecc749bdfc9aa2d4f1b570898862d6f 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -10010,6 +10010,25 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="DesktopIOSPromotion.CompletionTime" units="hours">
+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    [IOS] Time between when the user initiated send SMS action on a specific
+    entry point promotion on desktop and user signing in Chrome iOS app. Each

[Mark P, 2017/01/20 17:43:40]

This doesn't answer my question.  Is this time recorded based on a server
timestamp or a client one?

[mrefaat, 2017/01/20 19:14:59]

client one.

[Mark P, 2017/01/20 19:40:06]

And what about the time for user initiated the SMS action on desktop.  Is that a
client one too?

The description here should warn that both of these are client times (or one is
a client time and one is a server time), and in any case on different machines
so if one or either clock is wrong, then the results will be wrong.

Depending on the accuracy you need, you may want server times.  IIRC, 1% of
desktop users have their clock set wrong by more than a day.

[mrefaat, 2017/01/24 19:57:19]

Both will be client time, we are targeting desktop and mobile of same user so
there is a high chance that both devices are on the time zone and there will
some accounted probability to have errors 

+    entry point promotion will be logged separately using suffixes.
+  </summary>
+</histogram>
+
+<histogram name="DesktopIOSPromotion.IOSSigninReason"
+    enum="DesktopIOSPromotionEntryPoint">
+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    [IOS] For users who sign-in on Chrome for iOS, the type of the desktop iOS
+    promotion that was shown to the user. This will only be logged if at least

[Mark P, 2017/01/20 17:43:40]

If this transformation I propose correct?
This will only be logged if at least one promotion was shown to this user on the
last 7 days.
->
This will be logged for each promotion shown to this user on the last 7 days.

Otherwise you need to explain how you choose which particular entry point to log
if multiple were shown.

[mrefaat, 2017/01/20 19:14:59]

i should have marked this as not ready for review sorry - i'm still working on
it. But i'll be logging all the entry points users saw if at least one was shown
on the last 7 days.

+    one promotion was shown to this user on the last 7 days.
+  </summary>
+</histogram>
+
 <histogram name="DevTools.ActionTaken" enum="DevToolsAction">
   <owner>sergeyv@chromium.org</owner>
   <owner>vsevik@chromium.org</owner>
@@ -83192,6 +83211,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="12" label="Tab capturer created without audio capturer."/>
 </enum>
 
+<enum name="DesktopIOSPromotionEntryPoint" type="int">
+  <int value="1" label="Save Passwords new bubble."/>
+  <int value="2" label="Bookmarks new bubble."/>
+  <int value="3" label="Bookmarks existing bubble."/>
+  <int value="4" label="HistoryPage."/>
+</enum>
+
 <enum name="DesktopSearchRedirectionInfobarCloseAction" type="int">
   <int value="0" label="Clicked the 'Manage search settings' link"/>
   <int value="1" label="Clicked the dismiss button"/>
@@ -111853,6 +111879,22 @@ value.
       name="Prerender.SimulatedLocalBrowsingPLT_PrerenderNoUse"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="DesktopIOSEntryPoints" separator="."
+    ordering="prefix">
+  <suffix name="SavePasswordsNewBubble"/>
+  <suffix name="BookmarksNewBubble"/>
+  <suffix name="BookmarksExistingBubble"/>
+  <suffix name="HistoryPage"/>
+  <affected-histogram name="DesktopIOSPromotion.CompletionTime"/>
+</histogram_suffixes>
+
+<histogram_suffixes name="DesktopIOSPromotionSMSSent" separator="."
+    ordering="prefix">
+  <suffix name="SMSSent" label="SMS sent from the promotion."/>
+  <suffix name="NoSMS" label="No SMS was sent from the promotion."/>
+  <affected-histogram name="DesktopIOSPromotion.IOSSigninReason"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="DiskUsagePerUserCount" separator=".">
   <suffix name="1User" label="Only 1 user exists on device."/>
   <suffix name="2Users" label="2 users exist on device."/>