Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: services/device/device_service.h

Issue 2643713002: Port BatteryMonitor into Device Service (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/device/device_service.h
diff --git a/services/device/device_service.h b/services/device/device_service.h
index e08b6320e60e920a3d7172d42ccd1b5f059b61ec..69dae15034de59a69fce62016813befa6d03abef 100644
--- a/services/device/device_service.h
+++ b/services/device/device_service.h
@@ -6,10 +6,12 @@
#define SERVICES_DEVICE_DEVICE_SERVICE_H_
#include "base/memory/ref_counted.h"
+#include "device/battery/battery_monitor.mojom.h"
#include "device/power_monitor/public/interfaces/power_monitor.mojom.h"
#include "device/time_zone_monitor/public/interfaces/time_zone_monitor.mojom.h"
#include "mojo/public/cpp/bindings/binding_set.h"
#include "services/service_manager/public/cpp/interface_factory.h"
+#include "services/service_manager/public/cpp/interface_provider.h"
#include "services/service_manager/public/cpp/service.h"
namespace device {
@@ -21,6 +23,10 @@ std::unique_ptr<service_manager::Service> CreateDeviceService(
class DeviceService
: public service_manager::Service,
+#if !defined(OS_ANDROID)
+ // On Android the Device Service provides BatteryMonitor via Java.
+ public service_manager::InterfaceFactory<BatteryMonitor>,
+#endif
public service_manager::InterfaceFactory<mojom::PowerMonitor>,
public service_manager::InterfaceFactory<mojom::TimeZoneMonitor> {
public:
@@ -33,6 +39,12 @@ class DeviceService
bool OnConnect(const service_manager::ServiceInfo& remote_info,
service_manager::InterfaceRegistry* registry) override;
+#if !defined(OS_ANDROID)
+ // InterfaceFactory<BatteryMonitor>:
+ void Create(const service_manager::Identity& remote_identity,
+ BatteryMonitorRequest request) override;
+#endif
+
// InterfaceFactory<mojom::PowerMonitor>:
void Create(const service_manager::Identity& remote_identity,
mojom::PowerMonitorRequest request) override;
@@ -41,6 +53,17 @@ class DeviceService
void Create(const service_manager::Identity& remote_identity,
mojom::TimeZoneMonitorRequest request) override;
+#if defined(OS_ANDROID)
+ // Binds |java_interface_provider_| to an interface registry that exposes
+ // factories for the interfaces that are provided via Java on Android.
+ service_manager::InterfaceProvider* GetJavaInterfaceProvider();
+
+ // InterfaceProvider that is bound to the Java-side interface registry.
+ service_manager::InterfaceProvider java_interface_provider_;
+
+ bool java_interface_provider_initialized_;
+#endif
+
std::unique_ptr<device::TimeZoneMonitor> time_zone_monitor_;
scoped_refptr<base::SingleThreadTaskRunner> file_task_runner_;

Powered by Google App Engine
This is Rietveld 408576698