Implement constructor kinds in the VM mirrors.

tests/lib/mirrors/constructor_kinds_test.dart

Index: tests/lib/mirrors/constructor_kinds_test.dart
diff --git a/tests/lib/mirrors/constructor_kinds_test.dart b/tests/lib/mirrors/constructor_kinds_test.dart
index f3339ca844e068deb948027e1289f485ccc3dd13..2ea483a14c3aabefb2c84f601ffeb00c167d04bf 100644
--- a/tests/lib/mirrors/constructor_kinds_test.dart
+++ b/tests/lib/mirrors/constructor_kinds_test.dart
@@ -42,45 +42,44 @@ main() {
   Expect.isFalse(mm.isRedirectingConstructor);
   Expect.isFalse(mm.isConstConstructor);
 
-
   cm = reflectClass(Class);
 
-  mm = cm.constructors[#generative];
+  mm = cm.constructors[#Class.generative];
   Expect.isTrue(mm.isConstructor);
   Expect.isTrue(mm.isGenerativeConstructor);
   Expect.isFalse(mm.isFactoryConstructor);
   Expect.isFalse(mm.isRedirectingConstructor);
   Expect.isFalse(mm.isConstConstructor);
 
-  mm = cm.constructors[#redirectingGenerative];
+  mm = cm.constructors[#Class.redirectingGenerative];
   Expect.isTrue(mm.isConstructor);
   Expect.isTrue(mm.isGenerativeConstructor);
   Expect.isFalse(mm.isFactoryConstructor);
   Expect.isTrue(mm.isRedirectingConstructor);
   Expect.isFalse(mm.isConstConstructor);
 
-  mm = cm.constructors[#faktory];
+  mm = cm.constructors[#Class.faktory];
   Expect.isTrue(mm.isConstructor);
   Expect.isFalse(mm.isGenerativeConstructor);
   Expect.isTrue(mm.isFactoryConstructor);
   Expect.isFalse(mm.isRedirectingConstructor);
   Expect.isFalse(mm.isConstConstructor);
 
-  mm = cm.constructors[#redirectingFactory];
+  mm = cm.constructors[#Class.redirectingFactory];
   Expect.isTrue(mm.isConstructor);
   Expect.isFalse(mm.isGenerativeConstructor);
   Expect.isTrue(mm.isFactoryConstructor);
   Expect.isTrue(mm.isRedirectingConstructor);
   Expect.isFalse(mm.isConstConstructor);
 
-  mm = cm.constructors[#constGenerative];
+  mm = cm.constructors[#Class.constGenerative];
   Expect.isTrue(mm.isConstructor);
   Expect.isTrue(mm.isGenerativeConstructor);
   Expect.isFalse(mm.isFactoryConstructor);
   Expect.isFalse(mm.isRedirectingConstructor);
   Expect.isTrue(mm.isConstConstructor);
 
-  mm = cm.constructors[#constRedirectingGenerative];
+  mm = cm.constructors[#Class.constRedirectingGenerative];
   Expect.isTrue(mm.isConstructor);
   Expect.isTrue(mm.isGenerativeConstructor);
   Expect.isFalse(mm.isFactoryConstructor);
@@ -88,14 +87,14 @@ main() {
   Expect.isTrue(mm.isConstConstructor);
 
   // Not legal.
-  // mm = cm.constructors[#constFaktory];
+  // mm = cm.constructors[#Class.constFaktory];
   // Expect.isTrue(mm.isConstructor);
   // Expect.isFalse(mm.isGenerativeConstructor);
   // Expect.isTrue(mm.isFactoryConstructor);
   // Expect.isFalse(mm.isRedirectingConstructor);
   // Expect.isTrue(mm.isConstConstructor);
 
-  mm = cm.constructors[#constRedirectingFactory];
+  mm = cm.constructors[#Class.constRedirectingFactory];

[siva, 2013/10/09 16:05:50]

I was initially confused by this naming pattern for constructors,
maybe it would be more readable to make the names explicit
Class.generativeConstructor
Class.redirectingGenerativeConstructor
Class.factoryConstructor
Class.redirectingFactoryConstructor
Class.constGenerativeConstructor
Class.constRedirectingGenerativeConstructor
Class.constRedirectingFactoryConstructor

[rmacnak, 2013/10/09 17:13:51]

Fixed. I notice the VM internally is inconsistent about whether constructor
means generative-or-factory-constructor (per spec) or means
generative-constructor. Presumably this reflects an earlier version of Dart
without factory constructors.

   Expect.isTrue(mm.isConstructor);
   Expect.isFalse(mm.isGenerativeConstructor);
   Expect.isTrue(mm.isFactoryConstructor);