Implement constructor kinds in the VM mirrors.

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 1681 matching lines @@
   bool is_intrinsic() const {
     return IntrinsicBit::decode(raw_ptr()->kind_tag_);
   }
   void set_is_intrinsic(bool value) const;
 
   bool is_recognized() const {
     return RecognizedBit::decode(raw_ptr()->kind_tag_);
   }
   void set_is_recognized(bool value) const;
 
+  bool is_redirecting() const {
+    return RedirectingBit::decode(raw_ptr()->kind_tag_);
+  }
+  void set_is_redirecting(bool value) const;
+
   bool HasOptimizedCode() const;
 
   // Returns true if the argument counts are valid for calling this function.
   // Otherwise, it returns false and the reason (if error_message is not NULL).
   bool AreValidArgumentCounts(intptr_t num_arguments,
                               intptr_t num_named_arguments,
                               String* error_message) const;
 
   // Returns true if the total argument count and the names of optional
   // arguments are valid for calling this function.
@@ skipping 139 matching lines @@
     kConstBit = 1,
     kOptimizableBit = 2,
     kInlinableBit = 3,
     kHasFinallyBit = 4,
     kNativeBit = 5,
     kAbstractBit = 6,
     kExternalBit = 7,
     kVisibleBit = 8,
     kIntrinsicBit = 9,
     kRecognizedBit = 10,
-    kKindTagBit = 11,
+    kRedirectingBit = 11,

[rmacnak, 2013/10/09 01:24:43]

And now all 16 bits are used :/

[hausner, 2013/10/09 05:23:03]

Dang, I should have grabbed this bit a long time ago to mark implicit
constructors :)

On 2013/10/09 01:24:43, Ryan Macnak wrote:

+    kKindTagBit = 12,
     kKindTagSize = 4,
   };
   class StaticBit : public BitField<bool, kStaticBit, 1> {};
   class ConstBit : public BitField<bool, kConstBit, 1> {};
   class OptimizableBit : public BitField<bool, kOptimizableBit, 1> {};
   class InlinableBit : public BitField<bool, kInlinableBit, 1> {};
   class HasFinallyBit : public BitField<bool, kHasFinallyBit, 1> {};
   class NativeBit : public BitField<bool, kNativeBit, 1> {};
   class AbstractBit : public BitField<bool, kAbstractBit, 1> {};
   class ExternalBit : public BitField<bool, kExternalBit, 1> {};
   class VisibleBit : public BitField<bool, kVisibleBit, 1> {};
   class IntrinsicBit : public BitField<bool, kIntrinsicBit, 1> {};
   class RecognizedBit : public BitField<bool, kRecognizedBit, 1> {};
+  class RedirectingBit : public BitField<bool, kRedirectingBit, 1> {};
   class KindBits :
     public BitField<RawFunction::Kind, kKindTagBit, kKindTagSize> {};  // NOLINT
 
   void set_name(const String& value) const;
   void set_kind(RawFunction::Kind value) const;
   void set_is_static(bool value) const;
   void set_is_const(bool value) const;
   void set_is_external(bool value) const;
   void set_parent_function(const Function& value) const;
   void set_owner(const Object& value) const;
@@ skipping 4358 matching lines @@
 
 
 RawObject* MegamorphicCache::GetTargetFunction(const Array& array,
                                                intptr_t index) {
   return array.At((index * kEntryLength) + kTargetFunctionIndex);
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_