Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Side by Side Diff: chrome/browser/ui/bookmarks/bookmark_tab_helper.h

Issue 2643593002: Convert BookmarkTabHelper to use the new navigation callbacks. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/bookmarks/bookmark_tab_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_TAB_HELPER_H_
6 #define CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_TAB_HELPER_H_ 6 #define CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_TAB_HELPER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "components/bookmarks/browser/base_bookmark_model_observer.h" 9 #include "components/bookmarks/browser/base_bookmark_model_observer.h"
10 #include "content/public/browser/reload_type.h" 10 #include "content/public/browser/reload_type.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 const bookmarks::BookmarkNode* parent, 78 const bookmarks::BookmarkNode* parent,
79 int old_index, 79 int old_index,
80 const bookmarks::BookmarkNode* node, 80 const bookmarks::BookmarkNode* node,
81 const std::set<GURL>& removed_urls) override; 81 const std::set<GURL>& removed_urls) override;
82 void BookmarkAllUserNodesRemoved(bookmarks::BookmarkModel* model, 82 void BookmarkAllUserNodesRemoved(bookmarks::BookmarkModel* model,
83 const std::set<GURL>& removed_urls) override; 83 const std::set<GURL>& removed_urls) override;
84 void BookmarkNodeChanged(bookmarks::BookmarkModel* model, 84 void BookmarkNodeChanged(bookmarks::BookmarkModel* model,
85 const bookmarks::BookmarkNode* node) override; 85 const bookmarks::BookmarkNode* node) override;
86 86
87 // Overridden from content::WebContentsObserver: 87 // Overridden from content::WebContentsObserver:
88 void DidNavigateMainFrame( 88 void DidStartNavigation(
89 const content::LoadCommittedDetails& details, 89 content::NavigationHandle* navigation_handle) override;
90 const content::FrameNavigateParams& params) override; 90 void DidFinishNavigation(
91 void DidStartNavigationToPendingEntry( 91 content::NavigationHandle* navigation_handle) override;
92 const GURL& url,
93 content::ReloadType reload_type) override;
94 void DidAttachInterstitialPage() override; 92 void DidAttachInterstitialPage() override;
95 void DidDetachInterstitialPage() override; 93 void DidDetachInterstitialPage() override;
96 94
97 // Whether the current URL is starred. 95 // Whether the current URL is starred.
98 bool is_starred_; 96 bool is_starred_;
99 97
100 bookmarks::BookmarkModel* bookmark_model_; 98 bookmarks::BookmarkModel* bookmark_model_;
101 99
102 // Our delegate, to notify when the url starred changed. 100 // Our delegate, to notify when the url starred changed.
103 BookmarkTabHelperDelegate* delegate_; 101 BookmarkTabHelperDelegate* delegate_;
104 102
105 // The BookmarkDrag is used to forward bookmark drag and drop events to 103 // The BookmarkDrag is used to forward bookmark drag and drop events to
106 // extensions. 104 // extensions.
107 BookmarkDrag* bookmark_drag_; 105 BookmarkDrag* bookmark_drag_;
108 106
109 DISALLOW_COPY_AND_ASSIGN(BookmarkTabHelper); 107 DISALLOW_COPY_AND_ASSIGN(BookmarkTabHelper);
110 }; 108 };
111 109
112 #endif // CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_TAB_HELPER_H_ 110 #endif // CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/bookmarks/bookmark_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698