Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: tools/gn.py

Issue 2643583002: GN: Fix cross ARM64 and cross MIPS builds. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/toolchain/linux/BUILD.gn ('K') | « runtime/platform/globals.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn.py
diff --git a/tools/gn.py b/tools/gn.py
index 1e5120b927b06d68eece76e4d65f49bb156e50fa..0f55fce78d9432a4e881d424ebbaf5f27bc85f79 100755
--- a/tools/gn.py
+++ b/tools/gn.py
@@ -143,7 +143,7 @@ def to_gn_args(args, mode, arch, target_os):
# Force -mfloat-abi=hard and -mfpu=neon on Linux as we're specifying
# a gnueabihf compiler in //build/toolchain/linux BUILD.gn.
# TODO(zra): This will likely need some adjustment to build for armv6 etc.
- hard_float = (gn_args['target_cpu'].startswith('arm') and
+ hard_float = ((gn_args['target_cpu'] == 'arm') and
zra 2017/01/18 03:21:33 Add a TODO that this will need to change if we wan
rmacnak 2017/01/20 22:54:47 Added branches that throw with an unimplemented me
(gn_args['target_os'] == 'linux'))
if hard_float:
gn_args['arm_float_abi'] = 'hard'
« build/toolchain/linux/BUILD.gn ('K') | « runtime/platform/globals.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698