GN: Fix cross ARM64 and cross MIPS builds.

GN: Fix cross ARM64 and cross MIPS builds.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/4f598c584d7e4f34162efa5b179af62cd201f554

[rmacnak, 2017-01-18 00:01:07]

rmacnak@google.com changed reviewers:
+ zra@google.com

[zra, 2017-01-18 03:21:33]

https://codereview.chromium.org/2643583002/diff/1/build/toolchain/linux/BUILD.gn
File build/toolchain/linux/BUILD.gn (right):

https://codereview.chromium.org/2643583002/diff/1/build/toolchain/linux/BUILD...
build/toolchain/linux/BUILD.gn:112: cc = "${toolchain_prefix}gcc -EL"
Please add these here instead: 
https://github.com/dart-lang/sdk/blob/master/build/config/compiler/BUILD.gn#L228

https://codereview.chromium.org/2643583002/diff/1/tools/gn.py
File tools/gn.py (right):

https://codereview.chromium.org/2643583002/diff/1/tools/gn.py#newcode146
tools/gn.py:146: hard_float = ((gn_args['target_cpu'] == 'arm') and
Add a TODO that this will need to change if we want to continue supporting armv6
and armv5te, or refine this test to include those but exclude arm64.

[rmacnak, 2017-01-20 22:54:47]

https://codereview.chromium.org/2643583002/diff/1/build/toolchain/linux/BUILD.gn
File build/toolchain/linux/BUILD.gn (right):

https://codereview.chromium.org/2643583002/diff/1/build/toolchain/linux/BUILD...
build/toolchain/linux/BUILD.gn:112: cc = "${toolchain_prefix}gcc -EL"
On 2017/01/18 03:21:33, zra wrote:
> Please add these here instead: 
>
https://github.com/dart-lang/sdk/blob/master/build/config/compiler/BUILD.gn#L228

Done.

https://codereview.chromium.org/2643583002/diff/1/tools/gn.py
File tools/gn.py (right):

https://codereview.chromium.org/2643583002/diff/1/tools/gn.py#newcode146
tools/gn.py:146: hard_float = ((gn_args['target_cpu'] == 'arm') and
On 2017/01/18 03:21:33, zra wrote:
> Add a TODO that this will need to change if we want to continue supporting
armv6
> and armv5te, or refine this test to include those but exclude arm64.

Added branches that throw with an unimplemented message for armv6/5te.

[zra, 2017-01-20 23:05:16]

lgtm

[rmacnak, 2017-01-20 23:44:29]

Description was changed from

==========
GN: Fix cross ARM64 and cross MIPS builds.
==========

to

==========
GN: Fix cross ARM64 and cross MIPS builds.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4f598c584d7e4f34162efa5b179af62cd201f554
==========

[rmacnak, 2017-01-20 23:44:30]

Committed patchset #2 (id:20001) manually as
4f598c584d7e4f34162efa5b179af62cd201f554 (presubmit successful).