[Chromecast] Reuse the Aura window manager across receiver apps.

chromecast/browser/android/cast_content_window_android.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/android/cast_content_window_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/memory/ptr_util.h"
 #include "chromecast/base/metrics/cast_metrics_helper.h"
@@ skipping 41 matching lines @@
 CastContentWindowAndroid::~CastContentWindowAndroid() {
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_CastContentWindowAndroid_onNativeDestroyed(env, java_window_.obj());
 }
 
 void CastContentWindowAndroid::SetTransparent() {
   transparent_ = true;
 }
 
 void CastContentWindowAndroid::ShowWebContents(
-    content::WebContents* web_contents) {
+    content::WebContents* web_contents,
+    CastWindowManager* window_manager) {

[derekjchow1, 2017/01/18 02:49:12]

DCHECK(window_manager).

Even if it's not used, it should be part of the API contract that window_manager
should not be nullptr.

[Joshua LeVasseur, 2017/01/18 18:26:35]

Done.

   JNIEnv* env = base::android::AttachCurrentThread();
   base::android::ScopedJavaLocalRef<jobject> java_web_contents =
       web_contents->GetJavaWebContents();
 
   Java_CastContentWindowAndroid_showWebContents(env, java_window_.obj(),
                                                 java_web_contents.obj());
 }
 
 std::unique_ptr<content::WebContents>
 CastContentWindowAndroid::CreateWebContents(
@@ skipping 53 matching lines @@
     const base::android::JavaParamRef<jobject>& jcaller,
     int keycode) {
   ui::KeyEvent key_event(ui::ET_KEY_PRESSED,
                          ui::KeyboardCodeFromAndroidKeyCode(keycode),
                          ui::EF_NONE);
   delegate_->OnKeyEvent(key_event);
 }
 
 }  // namespace shell
 }  // namespace chromecast