Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: remoting/client/client_telemetry_logger_unittest.cc

Issue 2643483003: [Remoting Android] Refactor ClientTelemetryLogger (Closed)
Patch Set: PTAL Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/client_telemetry_logger.cc ('k') | remoting/client/jni/chromoting_jni_instance.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/client_telemetry_logger_unittest.cc
diff --git a/remoting/client/client_telemetry_logger_unittest.cc b/remoting/client/client_telemetry_logger_unittest.cc
index faf5647fb1d825262410749f711fc92973502bd3..0476d35a7aa560676c8dce8780e73b1a97b6e464 100644
--- a/remoting/client/client_telemetry_logger_unittest.cc
+++ b/remoting/client/client_telemetry_logger_unittest.cc
@@ -97,16 +97,14 @@ class ClientTelemetryLoggerTest : public testing::Test {
void SetUp() override;
protected:
- // |log_writer_| will be owned by |logger_| and freed when |logger_|
- // destructs. Feel free to use this reference in the test.
- FakeLogWriter* log_writer_ = nullptr;
+ std::unique_ptr<FakeLogWriter> log_writer_;
std::unique_ptr<ClientTelemetryLogger> logger_;
};
void ClientTelemetryLoggerTest::SetUp() {
- log_writer_ = new FakeLogWriter();
- logger_.reset(new ClientTelemetryLogger(ChromotingEvent::Mode::ME2ME));
- logger_->StartForTest(base::WrapUnique(log_writer_));
+ log_writer_.reset(new FakeLogWriter());
+ logger_.reset(new ClientTelemetryLogger(log_writer_.get(),
+ ChromotingEvent::Mode::ME2ME));
}
TEST_F(ClientTelemetryLoggerTest, LogSessionStateChange) {
@@ -174,13 +172,4 @@ TEST_F(ClientTelemetryLoggerTest, SessionIdExpiration) {
EXPECT_NE(last_id, logger_->session_id());
}
-TEST_F(ClientTelemetryLoggerTest, PassesThroughAuthTokenAndClosure) {
- std::string token("some token");
- base::Closure closure = base::Bind(&base::DoNothing);
- logger_->SetAuthToken(token);
- logger_->SetAuthClosure(closure);
- EXPECT_EQ(token, log_writer_->auth_token());
- EXPECT_TRUE(closure.Equals(log_writer_->auth_closure()));
-}
-
} // namespace remoting
« no previous file with comments | « remoting/client/client_telemetry_logger.cc ('k') | remoting/client/jni/chromoting_jni_instance.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698