Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

Issue 2643473002: [Presentation API] Allow PresentationConnection state change to "Connecting" (Closed)
Patch Set: Address Mark and Bin's comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
index be94c78b5cbe27f3800a4a7eeafc31a025dc6703..d7ab9b43b9df7c1128c9b193fe93feed396a2a44 100644
--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
@@ -423,8 +423,8 @@ void PresentationConnection::didChangeState(
m_state = state;
switch (m_state) {
+ // There is no event handler for state changes to Connecting.
case WebPresentationConnectionState::Connecting:
- NOTREACHED();
return;
case WebPresentationConnectionState::Connected:
dispatchStateChangeEvent(Event::create(EventTypeNames::connect));
« no previous file with comments | « third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698