Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: content/browser/renderer_host/media/video_capture_controller.h

Issue 2643463002: Fix for Crash in VideoCaptureController::DoNewBufferOnIOThread (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/media/video_capture_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/media/video_capture_controller.h
diff --git a/content/browser/renderer_host/media/video_capture_controller.h b/content/browser/renderer_host/media/video_capture_controller.h
index 4be8085bbf67c870971c272da674c7e897691234..f5484188f96df8781d851da5829e63f402a7cc2c 100644
--- a/content/browser/renderer_host/media/video_capture_controller.h
+++ b/content/browser/renderer_host/media/video_capture_controller.h
@@ -67,12 +67,10 @@ class CONTENT_EXPORT VideoCaptureController : public media::VideoFrameReceiver {
base::WeakPtr<VideoCaptureController> GetWeakPtrForIOThread();
- // Factory code creating instances of VideoCaptureController must set a
- // FrameBufferPool before any of the media::VideoFrameReceiver are used.
- // Setting the observer is done in this method separate from the constructor
- // in order to allow use the media::VideoFrameReceiver methods
- // before the observer can be provided. (This is the case with
- // VideoCaptureManager).
+ // A FrameBufferPool must to be set in order for video frames to be
+ // processed. While no FrameBufferPool is set, incoming video frames are
+ // ignored. It is legal to reset a previously set FrameBufferPool by calling
+ // this method with a nullptr.
void SetFrameBufferPool(
std::unique_ptr<media::FrameBufferPool> frame_buffer_pool);
« no previous file with comments | « no previous file | content/browser/renderer_host/media/video_capture_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698