Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

Issue 2643453002: Replace deprecated calls to GetMetadata in Physical Web Zine provider (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h
diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h
index 0a1e3c8c17cdb91ca9517fa60c921b61344459bf..1cc24dba665ca59f640ede9dcc8aad07de428c71 100644
--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h
+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h
@@ -9,18 +9,21 @@
#include <vector>
#include "base/callback_forward.h"
-#include "base/values.h"
#include "components/ntp_snippets/category.h"
#include "components/ntp_snippets/category_status.h"
#include "components/ntp_snippets/content_suggestion.h"
#include "components/ntp_snippets/content_suggestions_provider.h"
-#include "components/physical_web/data_source/physical_web_data_source.h"
#include "components/physical_web/data_source/physical_web_listener.h"
class PrefRegistrySimple;
class PrefService;
class GURL;
vitaliii 2017/01/18 08:03:34 Please sort.
mattreynolds 2017/01/18 22:26:12 Done.
+namespace physical_web {
+class PhysicalWebDataSource;
+struct Metadata;
+}
vitaliii 2017/01/18 08:03:34 } // namespace physical_web
mattreynolds 2017/01/18 22:26:13 Done.
+
namespace ntp_snippets {
// Provides content suggestions from the Physical Web Service.
@@ -75,7 +78,7 @@ class PhysicalWebPageSuggestionsProvider
// Converts an Physical Web page to a ContentSuggestion.
ContentSuggestion ConvertPhysicalWebPage(
- const base::DictionaryValue& page) const;
+ const physical_web::Metadata& page) const;
// PhysicalWebListener implementation.
void OnFound(const GURL& url) override;

Powered by Google App Engine
This is Rietveld 408576698