Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: src/wasm/wasm-interpreter.h

Issue 2643443002: [wasm] Improve pimpl implementation in WasmInterpreter::Thread (Closed)
Patch Set: Add comment about risky reinterpret_cast Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/wasm/wasm-interpreter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-interpreter.h
diff --git a/src/wasm/wasm-interpreter.h b/src/wasm/wasm-interpreter.h
index ef74e5b32fb0e874a1c26a52420f7c9f324e5903..217c8b37f0bf8cca7702000b8ef7f142ab07bfc6 100644
--- a/src/wasm/wasm-interpreter.h
+++ b/src/wasm/wasm-interpreter.h
@@ -113,13 +113,12 @@ class V8_EXPORT_PRIVATE WasmInterpreter {
enum State { STOPPED, RUNNING, PAUSED, FINISHED, TRAPPED };
// Representation of a thread in the interpreter.
- class ThreadImpl;
class V8_EXPORT_PRIVATE Thread {
- ThreadImpl* impl_;
+ // Don't instante Threads; they will be allocated as ThreadImpl in the
+ // interpreter implementation.
+ Thread() = delete;
public:
- explicit Thread(ThreadImpl*);
-
// Execution control.
State state();
void PushFrame(const WasmFunction* function, WasmVal* args);
« no previous file with comments | « no previous file | src/wasm/wasm-interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698