third_party/WebKit/Source/core/layout/line/InlineTextBox.h - Issue 2643413002: Fix 'text-underline-position: under' to use em height ascent/descent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineTextBox.h

Issue 2643413002: Fix 'text-underline-position: under' to use em height ascent/descent (Closed)

Patch Set: eae review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/InlineTextBox.h

diff --git a/third_party/WebKit/Source/core/layout/line/InlineTextBox.h b/third_party/WebKit/Source/core/layout/line/InlineTextBox.h

index 9c311420978fbec74d663a4d02906ee67472e46b..319a55890ec1024be9e13fa32ec9cf807a0ab08f 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineTextBox.h

+++ b/third_party/WebKit/Source/core/layout/line/InlineTextBox.h

@@ -99,6 +99,9 @@ class CORE_EXPORT InlineTextBox : public InlineBox {

bool GetEmphasisMarkPosition(const ComputedStyle&,

TextEmphasisPosition&) const;

+ LayoutUnit OffsetTo(LineVerticalPositionType, FontBaseline) const;

+ LayoutUnit VerticalPosition(LineVerticalPositionType, FontBaseline) const;

LayoutRect LogicalOverflowRect() const;

void SetLogicalOverflowRect(const LayoutRect&);

LayoutUnit LogicalTopVisualOverflow() const {