Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineFlowBox.h

Issue 2643413002: Fix 'text-underline-position: under' to use em height ascent/descent (Closed)
Patch Set: eae review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/line/InlineBox.h ('k') | third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp » ('j') | third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
diff --git a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
index 572d78ae29fd16b7a4bf38f76e6191f386f5f25c..1c1a3a40be56d5ad4313bd826d2ce6a6ce49d42c 100644
--- a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
+++ b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
@@ -392,10 +392,10 @@ class InlineFlowBox : public InlineBox {
logical_visual_overflow, line_top, line_bottom);
}
- LayoutUnit MaxLogicalBottomForUnderline(LineLayoutItem decoration_object,
- LayoutUnit max_logical_bottom) const;
- LayoutUnit MinLogicalTopForUnderline(LineLayoutItem decoration_object,
- LayoutUnit min_logical_top) const;
+ LayoutUnit FarthestPositionForUnderline(LineLayoutItem decorating_box,
+ LineVerticalPositionType,
+ FontBaseline,
+ LayoutUnit current) const;
private:
void PlaceBoxRangeInInlineDirection(InlineBox* first_child,
« no previous file with comments | « third_party/WebKit/Source/core/layout/line/InlineBox.h ('k') | third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp » ('j') | third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698