Issue 26434002: Cleanup: Add more conversion helpers for usage.

Issue 26434002: Cleanup: Add more conversion helpers for usage. (Closed)

Created:
7 years, 2 months ago by r.kasibhatla

Modified:
7 years, 2 months ago

Reviewers:
tkent, jamesr, Julien - ping for review

CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Cleanup: Add more conversion helpers for usage. Adding toDeviceMotionEvent and toDeviceOrientationEvent conversion functions to replace static_cast, and update toWheelEvent and toGestureEvent so that they accept NULL argument for consistency. R=tkent, jamesr BUG=None TEST=None; No behavior changes; Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159223

Patch Set 1 #

Total comments: 17

Patch Set 2 : #

Patch Set 3 : Updated to ToT. Patch for landing. #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -11 lines)			Patch
M	Source/core/dom/Node.cpp	View	1 2	2 chunks	+4 lines, -3 lines	0 comments	Download
M	Source/core/events/GestureEvent.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/events/WheelEvent.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/events/WheelEvent.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/shadow/SpinButtonElement.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/device_orientation/DeviceMotionController.cpp	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/modules/device_orientation/DeviceMotionEvent.h	View	1 2	1 chunk	+6 lines, -0 lines	1 comment	Download
M	Source/modules/device_orientation/DeviceOrientationEvent.h	View	1 2	1 chunk	+6 lines, -0 lines	1 comment	Download
M	Source/modules/device_orientation/NewDeviceOrientationController.cpp	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 16 (0 generated)

Expand Messages | Collapse Messages

tkent

Please split the change to small pieces. It's not welcome to handle multiple unrelated classes ...

7 years, 2 months ago (2013-10-08 05:24:03 UTC) #2

r.kasibhatla

https://codereview.chromium.org/26434002/diff/1/Source/core/events/GestureEvent.h File Source/core/events/GestureEvent.h (right): https://codereview.chromium.org/26434002/diff/1/Source/core/events/GestureEvent.h#newcode76 Source/core/events/GestureEvent.h:76: ASSERT_WITH_SECURITY_IMPLICATION(event && event->isGestureEvent()); On 2013/10/08 05:24:04, tkent wrote: > ...

7 years, 2 months ago (2013-10-08 09:40:15 UTC) #3

r.kasibhatla

On 2013/10/08 05:24:03, tkent wrote: > Please split the change to small pieces. It's not ...

7 years, 2 months ago (2013-10-08 09:41:45 UTC) #4

tkent

lgtm > Cleanup: Add more conversion helpers for usage. > > Adding more conversion functions ...

7 years, 2 months ago (2013-10-08 21:50:02 UTC) #5

tkent

> > Adding more conversion functions to replace static_cast of related > > typename objects. ...

7 years, 2 months ago (2013-10-08 21:53:22 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/26434002/11001

7 years, 2 months ago (2013-10-08 21:53:42 UTC) #7

commit-bot: I haz the power

Failed to apply patch for Source/core/dom/Node.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...

7 years, 2 months ago (2013-10-08 21:53:46 UTC) #8

Failed to apply patch for Source/core/dom/Node.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/Node.cpp
  Hunk #1 FAILED at 2386.
  Hunk #2 FAILED at 2407.
  2 out of 2 hunks FAILED -- saving rejects to file Source/core/dom/Node.cpp.rej

Patch:       Source/core/dom/Node.cpp
Index: Source/core/dom/Node.cpp
diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp
index
6bea5c1e67110e84b44eef0523eb5b53e3fed655..fd8b48b59ebf2ac71df8c9202ceca3351fa3ff6d
100644
--- a/Source/core/dom/Node.cpp
+++ b/Source/core/dom/Node.cpp
@@ -2386,9 +2386,10 @@ void Node::defaultEventHandler(Event* event)
         if (Page* page = document().page())
             page->contextMenuController().handleContextMenuEvent(event);
     } else if (eventType == eventNames().textInputEvent) {
-        if (event->hasInterface(eventNames().interfaceForTextEvent))
+        if (event->hasInterface(eventNames().interfaceForTextEvent)) {
             if (Frame* frame = document().frame())
-               
frame->eventHandler()->defaultTextInputEventHandler(static_cast<TextEvent*>(event));
+               
frame->eventHandler()->defaultTextInputEventHandler(toTextEvent(event));
+        }
 #if OS(WIN)
     } else if (eventType == eventNames().mousedownEvent &&
event->isMouseEvent()) {
         MouseEvent* mouseEvent = toMouseEvent(event);
@@ -2407,7 +2408,7 @@ void Node::defaultEventHandler(Event* event)
         }
 #endif
     } else if ((eventType == eventNames().wheelEvent || eventType ==
eventNames().mousewheelEvent) &&
event->hasInterface(eventNames().interfaceForWheelEvent)) {
-        WheelEvent* wheelEvent = static_cast<WheelEvent*>(event);
+        WheelEvent* wheelEvent = toWheelEvent(event);
 
         // If we don't have a renderer, send the wheel event to the first node
we find with a renderer.
         // This is needed for <option> and <optgroup> elements so that
<select>s get a wheel scroll.

r.kasibhatla

On 2013/10/08 21:53:46, I haz the power (commit-bot) wrote: > Failed to apply patch for ...

7 years, 2 months ago (2013-10-09 06:26:22 UTC) #9

On 2013/10/08 21:53:46, I haz the power (commit-bot) wrote:
> Failed to apply patch for Source/core/dom/Node.cpp:
> While running patch -p1 --forward --force --no-backup-if-mismatch;
>   patching file Source/core/dom/Node.cpp
>   Hunk #1 FAILED at 2386.
>   Hunk #2 FAILED at 2407.
>   2 out of 2 hunks FAILED -- saving rejects to file
Source/core/dom/Node.cpp.rej
> 
> Patch:       Source/core/dom/Node.cpp
> Index: Source/core/dom/Node.cpp
> diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp
> index
>
6bea5c1e67110e84b44eef0523eb5b53e3fed655..fd8b48b59ebf2ac71df8c9202ceca3351fa3ff6d
> 100644
> --- a/Source/core/dom/Node.cpp
> +++ b/Source/core/dom/Node.cpp
> @@ -2386,9 +2386,10 @@ void Node::defaultEventHandler(Event* event)
>          if (Page* page = document().page())
>              page->contextMenuController().handleContextMenuEvent(event);
>      } else if (eventType == eventNames().textInputEvent) {
> -        if (event->hasInterface(eventNames().interfaceForTextEvent))
> +        if (event->hasInterface(eventNames().interfaceForTextEvent)) {
>              if (Frame* frame = document().frame())
> -               
>
frame->eventHandler()->defaultTextInputEventHandler(static_cast<TextEvent*>(event));
> +               
> frame->eventHandler()->defaultTextInputEventHandler(toTextEvent(event));
> +        }
>  #if OS(WIN)
>      } else if (eventType == eventNames().mousedownEvent &&
> event->isMouseEvent()) {
>          MouseEvent* mouseEvent = toMouseEvent(event);
> @@ -2407,7 +2408,7 @@ void Node::defaultEventHandler(Event* event)
>          }
>  #endif
>      } else if ((eventType == eventNames().wheelEvent || eventType ==
> eventNames().mousewheelEvent) &&
> event->hasInterface(eventNames().interfaceForWheelEvent)) {
> -        WheelEvent* wheelEvent = static_cast<WheelEvent*>(event);
> +        WheelEvent* wheelEvent = toWheelEvent(event);
>  
>          // If we don't have a renderer, send the wheel event to the first
node
> we find with a renderer.
>          // This is needed for <option> and <optgroup> elements so that
> <select>s get a wheel scroll.

Updated the patch to ToT to resolve merge issues.
@tkent: Can you please stamp it?

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/26434002/19001

7 years, 2 months ago (2013-10-09 06:33:41 UTC) #10

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=9682

7 years, 2 months ago (2013-10-09 08:06:18 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/26434002/19001

7 years, 2 months ago (2013-10-09 08:37:27 UTC) #12

Julien - ping for review

This change's ASSERTs are tripping on several tests: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fdom%2FDeviceOrientation%2Fupdates.html%2Cfast%2Fdom%2FDeviceOrientation%2Fnull-values.html%2Cfast%2Fdom%2FDeviceOrientation%2Fmultiple-frames.html%2Cfast%2Fdom%2FDeviceOrientation%2Fadd-listener-from-callback.html%2Cfast%2Fdom%2FDeviceOrientation%2Fbasic-operation.html%2Cfast%2Fdom%2FDeviceOrientation%2Fno-synchronous-events.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fdom%2FDeviceMotion%2Ffire-last-event.html%2Cfast%2Fdom%2FDeviceMotion%2Fpage-visibility.html%2Cfast%2Fdom%2FDeviceMotion%2Fadd-listener-from-callback.html%2Cfast%2Fdom%2FDeviceMotion%2Fadd-during-dispatch.html%2Cfast%2Fdom%2FDeviceMotion%2Fnull-values.html I am going to revert ...

7 years, 2 months ago (2013-10-09 19:44:29 UTC) #14

tkent

https://codereview.chromium.org/26434002/diff/19001/Source/modules/device_orientation/DeviceMotionEvent.h File Source/modules/device_orientation/DeviceMotionEvent.h (right): https://codereview.chromium.org/26434002/diff/19001/Source/modules/device_orientation/DeviceMotionEvent.h#newcode73 Source/modules/device_orientation/DeviceMotionEvent.h:73: ASSERT_WITH_SECURITY_IMPLICATION(!event || event->interfaceName() == EventNames::devicemotion); EventNames::devicemotion should be eventNames().interfaceForDeviceMotionEvent. ...

7 years, 2 months ago (2013-10-10 01:51:13 UTC) #15

r.kasibhatla

7 years, 2 months ago (2013-10-10 04:00:55 UTC) #16

Message was sent while issue was closed.

On 2013/10/09 19:44:29, Julien Chaffraix wrote:
> This change's ASSERTs are tripping on several tests:
> 
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fas...
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fas...
> 
> I am going to revert the change. If you were on IRC sorry but I couldn't find
> you to give you a warning.

@julien:
I am on IRC with nickname as kphanee. 
I will check and update the issue with changes to remove flakiness.

Expand Messages | Collapse Messages