src/liveedit.cc - Issue 264333007: Add OnCompileError handler and v8::CompileError debug event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/liveedit.cc

Issue 264333007: Add OnCompileError handler and v8::CompileError debug event (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/liveedit.cc

diff --git a/src/liveedit.cc b/src/liveedit.cc

index d802d0dd9d88978bcfaa56f696a660e2291ea12d..46858503b021d81edd3c22daef665dc9b03b0a8b 100644

--- a/src/liveedit.cc

+++ b/src/liveedit.cc

@@ -1471,7 +1471,7 @@ Handle<Object> LiveEdit::ChangeScriptSource(Handle<Script> original_script,

Handle<Script> old_script = CreateScriptCopy(original_script);

old_script->set_name(String::cast(*old_script_name));

old_script_object = old_script;

- isolate->debug()->OnAfterCompile(old_script, Debug::SEND_WHEN_DEBUGGING);

+ isolate->debug()->OnAfterCompile(old_script);

} else {

old_script_object = isolate->factory()->null_value();

}