Reintroducing MallocHooks changes with fix for infinite loop in MallocHooks on Platform::Exit.

Reintroducing MallocHooks changes with fix for infinite loop in MallocHooks on Platform::Exit.

BUG=
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/7bf5d870174fc2f18126bdf5719ebb6209a2ab1d

[bkonyi, 2017-01-20 18:00:53]

bkonyi@google.com changed reviewers:
+ zra@google.com

[zra, 2017-01-20 18:13:28]

https://codereview.chromium.org/2643303003/diff/1/runtime/vm/malloc_hooks.cc
File runtime/vm/malloc_hooks.cc (right):

https://codereview.chromium.org/2643303003/diff/1/runtime/vm/malloc_hooks.cc#...
runtime/vm/malloc_hooks.cc:169: AddressMap* MallocHooksState::address_map_ = new
AddressMap();
Let's allocate this in InitOnce(), and delete it in TearDown(). The lock is the
only thing we don't have a good way to avoid leaking at the moment.

[bkonyi, 2017-01-20 20:13:53]

https://codereview.chromium.org/2643303003/diff/1/runtime/vm/malloc_hooks.cc
File runtime/vm/malloc_hooks.cc (right):

https://codereview.chromium.org/2643303003/diff/1/runtime/vm/malloc_hooks.cc#...
runtime/vm/malloc_hooks.cc:169: AddressMap* MallocHooksState::address_map_ = new
AddressMap();
On 2017/01/20 at 18:13:28, zra wrote:
> Let's allocate this in InitOnce(), and delete it in TearDown(). The lock is
the only thing we don't have a good way to avoid leaking at the moment.

I've moved the allocation inside of MallocHooksState's set_initialized and
cleanup in Reset.

[zra, 2017-01-20 20:23:13]

lgtm after function rename

https://codereview.chromium.org/2643303003/diff/20001/runtime/vm/malloc_hooks.cc
File runtime/vm/malloc_hooks.cc (right):

https://codereview.chromium.org/2643303003/diff/20001/runtime/vm/malloc_hooks...
runtime/vm/malloc_hooks.cc:111: static void set_initialized() {
Maybe rename this Init(). It's not really a setter since it doesn't take the
flag value as an argument.

https://codereview.chromium.org/2643303003/diff/20001/runtime/vm/malloc_hooks...
runtime/vm/malloc_hooks.cc:149: delete address_map_;
Likewise, maybe rename this Shutdown() or TearDown().

[bkonyi, 2017-01-20 23:27:06]

Description was changed from

==========
Reintroducing MallocHooks changes with fix for infinite loop in MallocHooks on
Platform::Exit.

BUG=
==========

to

==========
Reintroducing MallocHooks changes with fix for infinite loop in MallocHooks on
Platform::Exit.

BUG=
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7bf5d870174fc2f18126bdf5719ebb6209a2ab1d
==========

[bkonyi, 2017-01-20 23:27:07]

Committed patchset #3 (id:40001) manually as
7bf5d870174fc2f18126bdf5719ebb6209a2ab1d (presubmit successful).