Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2643293003: [Content suggestions] Report updates in the UI to UMA - cleanup (Closed)
Patch Set: Minor changes #2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
index 5863f0735a06df8829ad9c1f4ef2453dce2e91f9..a74ae55115000b5e1851ae42780091f85547780b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
@@ -357,20 +357,10 @@ public class SuggestionsSection extends InnerNode {
suggestions.size() - targetCountToAppend);
suggestions.subList(targetCountToAppend, suggestions.size()).clear();
}
-
- if (mNumberOfSuggestionsSeen == 1) {
- NewTabPageUma.recordUIUpdateResult(NewTabPageUma.UI_UPDATE_SUCCESS_1_SEEN);
- } else if (mNumberOfSuggestionsSeen == 2) {
- NewTabPageUma.recordUIUpdateResult(NewTabPageUma.UI_UPDATE_SUCCESS_2_SEEN);
- } else if (mNumberOfSuggestionsSeen == 3) {
- NewTabPageUma.recordUIUpdateResult(NewTabPageUma.UI_UPDATE_SUCCESS_3_SEEN);
- } else {
- NewTabPageUma.recordUIUpdateResult(
- NewTabPageUma.UI_UPDATE_SUCCESS_MORE_THAN_3_SEEN);
- }
- } else {
- NewTabPageUma.recordUIUpdateResult(NewTabPageUma.UI_UPDATE_SUCCESS_NONE_SEEN);
}
+ NewTabPageUma.recordNumberOfSuggestionsSeenBeforeUIUpdateSuccess(
+ mNumberOfSuggestionsSeen);
+ NewTabPageUma.recordUIUpdateResult(NewTabPageUma.UI_UPDATE_SUCCESS_REPLACED);
} else {
NewTabPageUma.recordUIUpdateResult(NewTabPageUma.UI_UPDATE_SUCCESS_APPENDED);
}

Powered by Google App Engine
This is Rietveld 408576698