Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: components/crash/content/app/fallback_crash_handler_win_unittest.cc

Issue 2643273002: Grab system and process memory stats into crash keys in fallback handler. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/crash/content/app/fallback_crash_handler_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/content/app/fallback_crash_handler_win_unittest.cc
diff --git a/components/crash/content/app/fallback_crash_handler_win_unittest.cc b/components/crash/content/app/fallback_crash_handler_win_unittest.cc
index f490a287da727855abcd46b4d50252370c802c24..cdd68d80da8a3af223bd4efea81b12082ef867ab 100644
--- a/components/crash/content/app/fallback_crash_handler_win_unittest.cc
+++ b/components/crash/content/app/fallback_crash_handler_win_unittest.cc
@@ -227,6 +227,29 @@ TEST_F(FallbackCrashHandlerWinTest, GenerateCrashDump) {
it = parameters.find("ptype");
EXPECT_NE(parameters.end(), it);
EXPECT_EQ(kProcessType, it->second);
+
+ uint64_t int_value;
+ it = parameters.find("ProcessPrivateUsage");
+ EXPECT_NE(parameters.end(), it);
+ EXPECT_TRUE(base::StringToUint64(it->second, &int_value));
+ EXPECT_NE(0U, int_value);
+
+ it = parameters.find("ProcessPeakWorkingSetSize");
+ EXPECT_NE(parameters.end(), it);
+ EXPECT_TRUE(base::StringToUint64(it->second, &int_value));
+ EXPECT_NE(0U, int_value);
+
+ it = parameters.find("SystemCommitRemaining");
+ EXPECT_NE(parameters.end(), it);
+ EXPECT_TRUE(base::StringToUint64(it->second, &int_value));
+ // TODO(siggi): disable if this flakes, though bots shouldn't be that hard up
+ // on memory :).
+ EXPECT_NE(0U, int_value);
+
+ it = parameters.find("SystemCommitLimit");
+ EXPECT_NE(parameters.end(), it);
+ EXPECT_TRUE(base::StringToUint64(it->second, &int_value));
+ EXPECT_NE(0U, int_value);
}
} // namespace crash_reporter
« no previous file with comments | « components/crash/content/app/fallback_crash_handler_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698