Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: media/remoting/remoting_cdm_context.h

Issue 2643253003: Media Remoting Clean-up: Less-redundant naming, style consistency, etc. (Closed)
Patch Set: REBASE Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/remoting/remoting_cdm.cc ('k') | media/remoting/remoting_cdm_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/remoting/remoting_cdm_context.h
diff --git a/media/remoting/remoting_cdm_context.h b/media/remoting/remoting_cdm_context.h
index f7c3284d1baccaac47d7c380915b41db34e3f4bf..306dd49650bdd1f6552f0bb2a6d76f6091deb904 100644
--- a/media/remoting/remoting_cdm_context.h
+++ b/media/remoting/remoting_cdm_context.h
@@ -8,11 +8,17 @@
#include "media/base/cdm_context.h"
namespace media {
+namespace remoting {
class RemotingCdm;
-class RemotingSourceImpl;
+class SharedSession;
// TODO(xjz): Merge this with erickung's implementation.
+// TODO(miu): This class should just be merged into RemotingCdm and implement
+// both the CDM and CdmContext interfaces. Also, replace the GetSharedSession()
+// accessor and move it to a new SharedSession::FromCdmContext() function. Then,
+// neither the controller nor renderer can gain direct access to the CDM impl.
+// See discussion in https://codereview.chromium.org/2643253003 for more info.
class RemotingCdmContext : public CdmContext {
public:
explicit RemotingCdmContext(RemotingCdm* remoting_cdm);
@@ -22,7 +28,7 @@ class RemotingCdmContext : public CdmContext {
// pointer to it. Otherwise, return nullptr.
static RemotingCdmContext* From(CdmContext* cdm_context);
- RemotingSourceImpl* GetRemotingSource();
+ SharedSession* GetSharedSession() const;
// CdmContext implementations.
Decryptor* GetDecryptor() override;
@@ -35,6 +41,7 @@ class RemotingCdmContext : public CdmContext {
DISALLOW_COPY_AND_ASSIGN(RemotingCdmContext);
};
+} // namespace remoting
} // namespace media
#endif // MEDIA_REMOTING_REMOTING_CDM_CONTEXT_H_
« no previous file with comments | « media/remoting/remoting_cdm.cc ('k') | media/remoting/remoting_cdm_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698