Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Unified Diff: media/remoting/interstitial.cc

Issue 2643253003: Media Remoting Clean-up: Less-redundant naming, style consistency, etc. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/remoting/interstitial.cc
diff --git a/media/remoting/remoting_interstitial_ui.cc b/media/remoting/interstitial.cc
similarity index 79%
rename from media/remoting/remoting_interstitial_ui.cc
rename to media/remoting/interstitial.cc
index fc0e28c33400e020f76704cad9d3437fdec63fa7..2591b76cbf37dc0a4fb9f7fb5043185d730c1988 100644
--- a/media/remoting/remoting_interstitial_ui.cc
+++ b/media/remoting/interstitial.cc
@@ -2,13 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "media/remoting/remoting_interstitial_ui.h"
+#include "media/remoting/interstitial.h"
#include "media/base/media_resources.h"
#include "media/base/video_frame.h"
#include "media/base/video_renderer_sink.h"
#include "media/base/video_util.h"
#include "skia/ext/image_operations.h"
+#include "third_party/skia/include/core/SkBitmap.h"
#include "third_party/skia/include/core/SkCanvas.h"
#include "third_party/skia/include/core/SkTypeface.h"
#include "third_party/skia/include/effects/SkBlurImageFilter.h"
@@ -19,6 +20,7 @@
#include "ui/gfx/vector_icons_public.h"
namespace media {
+namespace remoting {
namespace {
@@ -35,10 +37,10 @@ SkBitmap ResizeImage(const SkBitmap& image, const gfx::Size& scaled_size) {
}
void RenderCastMessage(const gfx::Size& canvas_size,
- RemotingInterstitialType type,
+ InterstitialType type,
SkCanvas* canvas) {
DCHECK(canvas);
- if (type == RemotingInterstitialType::BETWEEN_SESSIONS)
+ if (type == InterstitialType::BETWEEN_SESSIONS)
return;
// Blur the background image.
@@ -71,7 +73,7 @@ void RenderCastMessage(const gfx::Size& canvas_size,
// Draw the appropriate text.
const std::string remote_playback_message =
- (type == RemotingInterstitialType::IN_SESSION
+ (type == InterstitialType::IN_SESSION
? GetLocalizedStringUTF8(MEDIA_REMOTING_CASTING_VIDEO_TEXT)
: GetLocalizedStringUTF8(MEDIA_REMOTING_CAST_ERROR_TEXT));
size_t display_text_width = paint.measureText(remote_playback_message.data(),
@@ -84,7 +86,7 @@ void RenderCastMessage(const gfx::Size& canvas_size,
// Draw the appropriate Cast icon.
gfx::VectorIconId current_icon =
- (type == RemotingInterstitialType::IN_SESSION
+ (type == InterstitialType::IN_SESSION
? gfx::VectorIconId::MEDIA_ROUTER_ACTIVE
: gfx::VectorIconId::MEDIA_ROUTER_WARNING);
gfx::ImageSkia icon_image =
@@ -97,10 +99,9 @@ void RenderCastMessage(const gfx::Size& canvas_size,
&paint);
}
-scoped_refptr<VideoFrame> RenderInterstitialFrame(
- const SkBitmap& image,
- const gfx::Size& canvas_size,
- RemotingInterstitialType type) {
+scoped_refptr<VideoFrame> RenderInterstitialFrame(const SkBitmap& image,
+ const gfx::Size& canvas_size,
+ InterstitialType type) {
SkBitmap canvas_bitmap;
canvas_bitmap.allocN32Pixels(canvas_size.width(), canvas_size.height());
canvas_bitmap.eraseColor(SK_ColorBLACK);
@@ -111,7 +112,7 @@ scoped_refptr<VideoFrame> RenderInterstitialFrame(
gfx::Rect centered_rect = ComputeLetterboxRegion(
gfx::Rect(canvas_size), gfx::Size(image.width(), image.height()));
SkBitmap processed_image = ResizeImage(image, centered_rect.size());
- if (type != RemotingInterstitialType::BETWEEN_SESSIONS) {
+ if (type != InterstitialType::BETWEEN_SESSIONS) {
color_utils::HSL shift = {-1, 0, 0.2}; // Make monochromatic.
processed_image =
SkBitmapOperations::CreateHSLShiftedBitmap(processed_image, shift);
@@ -122,24 +123,24 @@ scoped_refptr<VideoFrame> RenderInterstitialFrame(
RenderCastMessage(canvas_size, type, &canvas);
// Create a new VideoFrame, copy the bitmap, then return it.
- scoped_refptr<media::VideoFrame> video_frame = media::VideoFrame::CreateFrame(
- media::PIXEL_FORMAT_I420, canvas_size, gfx::Rect(canvas_size),
- canvas_size, base::TimeDelta());
+ scoped_refptr<VideoFrame> video_frame = VideoFrame::CreateFrame(
+ PIXEL_FORMAT_I420, canvas_size, gfx::Rect(canvas_size), canvas_size,
+ base::TimeDelta());
canvas_bitmap.lockPixels();
- media::CopyRGBToVideoFrame(
- reinterpret_cast<uint8_t*>(canvas_bitmap.getPixels()),
- canvas_bitmap.rowBytes(),
- gfx::Rect(canvas_size.width(), canvas_size.height()), video_frame.get());
+ CopyRGBToVideoFrame(reinterpret_cast<uint8_t*>(canvas_bitmap.getPixels()),
+ canvas_bitmap.rowBytes(),
+ gfx::Rect(canvas_size.width(), canvas_size.height()),
+ video_frame.get());
canvas_bitmap.unlockPixels();
return video_frame;
}
} // namespace
-void PaintRemotingInterstitial(const SkBitmap& image,
- const gfx::Size& canvas_size,
- RemotingInterstitialType interstitial_type,
- VideoRendererSink* video_renderer_sink) {
+void PaintInterstitial(const SkBitmap& image,
+ const gfx::Size& canvas_size,
+ InterstitialType interstitial_type,
+ VideoRendererSink* video_renderer_sink) {
if (canvas_size.IsEmpty())
return;
@@ -151,4 +152,5 @@ void PaintRemotingInterstitial(const SkBitmap& image,
video_renderer_sink->PaintSingleFrame(interstitial);
}
+} // namespace remoting
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698