Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 2643253003: Media Remoting Clean-up: Less-redundant naming, style consistency, etc. (Closed)
Patch Set: Addressed 1st-round comments. UserExperienceController->RendererController Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 98
99 namespace gfx { 99 namespace gfx {
100 class Point; 100 class Point;
101 class Range; 101 class Range;
102 } 102 }
103 103
104 namespace media { 104 namespace media {
105 class CdmFactory; 105 class CdmFactory;
106 class DecoderFactory; 106 class DecoderFactory;
107 class MediaPermission; 107 class MediaPermission;
108 class RemotingRendererController;
109 class RemotingSinkObserver;
110 class RendererWebMediaPlayerDelegate; 108 class RendererWebMediaPlayerDelegate;
111 class SurfaceManager; 109 class SurfaceManager;
112 class UrlIndex; 110 class UrlIndex;
113 class WebEncryptedMediaClientImpl; 111 class WebEncryptedMediaClientImpl;
112
113 namespace remoting {
114 class SinkAvailabilityObserver;
115 } // namespace remoting
116
114 } // namespace media 117 } // namespace media
115 118
116 namespace service_manager { 119 namespace service_manager {
117 class InterfaceRegistry; 120 class InterfaceRegistry;
118 class InterfaceProvider; 121 class InterfaceProvider;
119 } 122 }
120 123
121 namespace url { 124 namespace url {
122 class Origin; 125 class Origin;
123 } 126 }
(...skipping 973 matching lines...) Expand 10 before | Expand all | Expand 10 after
1097 // Sends a reply to the current find operation handling if it was a 1100 // Sends a reply to the current find operation handling if it was a
1098 // synchronous find request. 1101 // synchronous find request.
1099 void SendFindReply(int request_id, 1102 void SendFindReply(int request_id,
1100 int match_count, 1103 int match_count,
1101 int ordinal, 1104 int ordinal,
1102 const blink::WebRect& selection_rect, 1105 const blink::WebRect& selection_rect,
1103 bool final_status_update); 1106 bool final_status_update);
1104 1107
1105 void InitializeBlameContext(RenderFrameImpl* parent_frame); 1108 void InitializeBlameContext(RenderFrameImpl* parent_frame);
1106 1109
1107 #if BUILDFLAG(ENABLE_MEDIA_REMOTING)
1108 // Creates the RemotingRendererController to control whether to switch to/from
1109 // media remoting from/to local playback.
1110 std::unique_ptr<media::RemotingRendererController>
1111 CreateRemotingRendererController();
1112 #endif
1113
1114 // Stores the WebLocalFrame we are associated with. This is null from the 1110 // Stores the WebLocalFrame we are associated with. This is null from the
1115 // constructor until BindToWebFrame is called, and it is null after 1111 // constructor until BindToWebFrame is called, and it is null after
1116 // frameDetached is called until destruction (which is asynchronous in the 1112 // frameDetached is called until destruction (which is asynchronous in the
1117 // case of the main frame, but not subframes). 1113 // case of the main frame, but not subframes).
1118 blink::WebLocalFrame* frame_; 1114 blink::WebLocalFrame* frame_;
1119 1115
1120 // Boolean value indicating whether this RenderFrameImpl object is for the 1116 // Boolean value indicating whether this RenderFrameImpl object is for the
1121 // main frame or not. It remains accurate during destruction, even when 1117 // main frame or not. It remains accurate during destruction, even when
1122 // |frame_| has been invalidated. 1118 // |frame_| has been invalidated.
1123 bool is_main_frame_; 1119 bool is_main_frame_;
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
1249 RendererMediaPlayerManager* media_player_manager_; 1245 RendererMediaPlayerManager* media_player_manager_;
1250 RendererMediaSessionManager* media_session_manager_; 1246 RendererMediaSessionManager* media_session_manager_;
1251 #endif 1247 #endif
1252 1248
1253 media::SurfaceManager* media_surface_manager_; 1249 media::SurfaceManager* media_surface_manager_;
1254 1250
1255 #if BUILDFLAG(ENABLE_MEDIA_REMOTING) 1251 #if BUILDFLAG(ENABLE_MEDIA_REMOTING)
1256 // Lazy-bound pointer to the RemoterFactory service in the browser 1252 // Lazy-bound pointer to the RemoterFactory service in the browser
1257 // process. Always use the GetRemoterFactory() accessor instead of this. 1253 // process. Always use the GetRemoterFactory() accessor instead of this.
1258 media::mojom::RemoterFactoryPtr remoter_factory_; 1254 media::mojom::RemoterFactoryPtr remoter_factory_;
1255
1259 // An observer for the remoting sink availability that is used by 1256 // An observer for the remoting sink availability that is used by
1260 // media::RemotingCdmFactory to initialize media::RemotingSourceImpl. Created 1257 // media::RemotingCdmFactory to initialize media::RemotingSourceImpl. Created
1261 // in the constructor of RenderFrameImpl to make sure 1258 // in the constructor of RenderFrameImpl to make sure
1262 // media::RemotingSourceImpl be intialized with correct availability info. 1259 // media::RemotingSourceImpl be intialized with correct availability info.
1263 // Own by media::RemotingCdmFactory after it is created. 1260 // Own by media::RemotingCdmFactory after it is created.
1264 std::unique_ptr<media::RemotingSinkObserver> remoting_sink_observer_; 1261 std::unique_ptr<media::remoting::SinkAvailabilityObserver>
1262 remoting_sink_observer_;
1265 #endif 1263 #endif
1266 1264
1267 // The CDM and decoder factory attached to this frame, lazily initialized. 1265 // The CDM and decoder factory attached to this frame, lazily initialized.
1268 std::unique_ptr<media::CdmFactory> cdm_factory_; 1266 std::unique_ptr<media::CdmFactory> cdm_factory_;
1269 std::unique_ptr<media::DecoderFactory> decoder_factory_; 1267 std::unique_ptr<media::DecoderFactory> decoder_factory_;
1270 1268
1271 // Media resource cache, lazily initialized. 1269 // Media resource cache, lazily initialized.
1272 linked_ptr<media::UrlIndex> url_index_; 1270 linked_ptr<media::UrlIndex> url_index_;
1273 1271
1274 // The devtools agent for this frame; only created for main frame and 1272 // The devtools agent for this frame; only created for main frame and
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
1382 bool browser_side_navigation_pending_ = false; 1380 bool browser_side_navigation_pending_ = false;
1383 1381
1384 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1382 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1385 1383
1386 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1384 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1387 }; 1385 };
1388 1386
1389 } // namespace content 1387 } // namespace content
1390 1388
1391 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1389 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698