content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 2643243002: Remove RenderWidgetHostImpl::SuppressEventsUntilKeyDown()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2643243002: Remove RenderWidgetHostImpl::SuppressEventsUntilKeyDown() (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index 6cd8721519cdb1180aab3f3ed001bbfe9164fed9..e2d5a9ea229d068a432222adb5780bece59108b4 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -1745,10 +1745,6 @@ void RenderWidgetHostViewAura::OnWindowFocused(aura::Window* gained_focus,

// Ask the system-wide IME to send all TextInputClient messages to |this|

// object.

input_method->SetFocusedTextInputClient(this);

- // Often the application can set focus to the view in response to a key

- // down. However, the following events shouldn't be sent to the web page.

- host_->SuppressEventsUntilKeyDown();

sadrul 2017/01/23 18:18:13 How does this play with ctrl+tab to move focus? i.

foolip 2017/01/24 05:25:21 Aha, another unintentional change caused by https:

}

BrowserAccessibilityManager* manager =

« no previous file with comments | « content/browser/renderer_host/render_widget_host_unittest.cc ('k') | no next file » | no next file with comments »