Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 2643243002: Remove RenderWidgetHostImpl::SuppressEventsUntilKeyDown() (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index 474b8bf251ab597edea4bd15944e4b8985e72cc6..a4df31f606c016a002921c5435d65347de04488a 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -83,7 +83,6 @@
#include "ui/base/clipboard/clipboard.h"
#include "ui/events/blink/web_input_event_traits.h"
#include "ui/events/event.h"
-#include "ui/events/keycodes/dom/dom_code.h"
#include "ui/events/keycodes/keyboard_codes.h"
#include "ui/gfx/color_space.h"
#include "ui/gfx/geometry/size_conversions.h"
@@ -454,10 +453,6 @@ void RenderWidgetHostImpl::SendScreenRects() {
waiting_for_screen_rects_ack_ = true;
}
-void RenderWidgetHostImpl::SuppressEventsUntilKeyDown() {
- suppress_events_until_keydown_ = true;
-}
-
void RenderWidgetHostImpl::FlushInput() {
input_router_->RequestNotificationWhenFlushed();
if (synthetic_gesture_controller_)
@@ -1209,14 +1204,7 @@ void RenderWidgetHostImpl::ForwardKeyboardEvent(
if (!WebInputEvent::isKeyboardEventType(key_event.type()))
return;
- // For PrintScreen, a lone KeyUp event arrives. Bypass the suppression in this
- // case, as a |SuppressEventsUntilKeyDown()| call otherwise causes the keyup
- // events to go missing.
- // TODO(foolip): Remove this special case by instead removing the
- // |SuppressEventsUntilKeyDown()| call. https://crbug.com/668969
- bool is_print_screen =
- static_cast<ui::DomCode>(key_event.domCode) == ui::DomCode::PRINT_SCREEN;
- if (suppress_events_until_keydown_ && !is_print_screen) {
+ if (suppress_events_until_keydown_) {
// If the preceding RawKeyDown event was handled by the browser, then we
// need to suppress all events generated by it until the next RawKeyDown or
// KeyDown event.

Powered by Google App Engine
This is Rietveld 408576698