third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp - Issue 2643203002: Rewrite blink->cc scroll offset logic for SPV2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

Issue 2643203002: Rewrite blink->cc scroll offset logic for SPV2 (Closed)

Patch Set: Move code back under updateScrollOffset Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

index 64460cec509b0811adbb79c02ec269fbf98195fe..80362d805cfa8e3a0007e738ceb4056e012aab69 100644

--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

@@ -717,7 +717,8 @@ void PaintArtifactCompositor::update(

int effectId = propertyTreeManager.switchToEffectNode(

*pendingLayer.propertyTreeState.effect());

- propertyTreeManager.updateScrollOffset(layer->id(), scrollId);

+ propertyTreeManager.updateScrollOffset(

+ pendingLayer.propertyTreeState.scroll());

layer->set_offset_to_transform_parent(layerOffset);

layer->SetElementId(pendingLayer.propertyTreeState.compositorElementId());

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp » ('j') | no next file with comments »