Rewrite blink->cc scroll offset logic for SPV2

third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/graphics/compositing/PropertyTreeManager.h"
 
 #include "cc/layers/layer.h"
 #include "cc/trees/clip_node.h"
 #include "cc/trees/effect_node.h"
 #include "cc/trees/property_tree.h"
@@ skipping 263 matching lines @@
     m_propertyTrees.element_id_to_scroll_node_index[compositorElementId] = id;
   }
 
   auto result = m_scrollNodeMap.set(scrollNode, id);
   DCHECK(result.isNewEntry);
   scrollTree().set_needs_update(true);
 
   return id;
 }
 
-void PropertyTreeManager::updateScrollOffset(int layerId, int scrollId) {
-  cc::ScrollNode& scrollNode = *scrollTree().Node(scrollId);
-  cc::TransformNode& transformNode =
-      *transformTree().Node(scrollNode.transform_id);
-
-  transformNode.scrolls = true;
+void PropertyTreeManager::updateScrollOffset(
+    const ScrollPaintPropertyNode* scrollNode) {
+  int scrollNodeId = ensureCompositorScrollNode(scrollNode);
+  cc::ScrollNode& compositorScrollNode = *scrollTree().Node(scrollNodeId);
+  cc::TransformNode& compositorTransformNode =
+      *transformTree().Node(compositorScrollNode.transform_id);
 
   // Blink creates a 2d transform node just for scroll offset whereas cc's
-  // transform node has a special scroll offset field. To handle this we
-  // adjust cc's transform node to remove the 2d scroll translation and
-  // let the cc scroll tree update the cc scroll offset.
-  DCHECK(transformNode.local.IsIdentityOr2DTranslation());
-  auto offset = transformNode.local.To2dTranslation();
-  transformNode.local.MakeIdentity();
-  scrollTree().SetScrollOffset(layerId,
-                               gfx::ScrollOffset(-offset.x(), -offset.y()));
-  scrollTree().set_needs_update(true);
+  // transform node has a special scroll offset field. To handle this we adjust
+  // cc's transform node to remove the 2d scroll translation and instead set the
+  // scroll_offset field.
+  auto* scrollOffsetTransform = scrollNode->scrollOffsetTranslation();
+  auto scrollOffsetSize = scrollOffsetTransform->matrix().to2DTranslation();
+  auto scrollOffset =
+      gfx::ScrollOffset(-scrollOffsetSize.width(), -scrollOffsetSize.height());
+  DCHECK(compositorTransformNode.local.IsIdentityOr2DTranslation());
+  compositorTransformNode.scroll_offset = scrollOffset;
+  compositorTransformNode.local.MakeIdentity();
+  compositorTransformNode.scrolls = true;
+  transformTree().set_needs_update(true);
+  // TODO(pdr): The scroll tree's scroll offset will need to be set here.
 }
 
 int PropertyTreeManager::switchToEffectNode(
     const EffectPaintPropertyNode& nextEffect) {
   const EffectPaintPropertyNode* ancestor =
       GeometryMapper::lowestCommonAncestor(currentEffectNode(), &nextEffect);
   DCHECK(ancestor) << "Malformed effect tree. All nodes must be descendant of "
                       "EffectPaintPropertyNode::root().";
   while (currentEffectNode() != ancestor)
     m_effectStack.pop_back();
@@ skipping 74 matching lines @@
   m_effectStack.push_back(BlinkEffectAndCcIdPair{nextEffect, effectNode.id});
 
   dummyLayer->set_property_tree_sequence_number(kPropertyTreeSequenceNumber);
   dummyLayer->SetTransformTreeIndex(kSecondaryRootNodeId);
   dummyLayer->SetClipTreeIndex(outputClipId);
   dummyLayer->SetEffectTreeIndex(effectNode.id);
   dummyLayer->SetScrollTreeIndex(kRealRootNodeId);
 }
 
 }  // namespace blink