Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 26432006: Remove unnecessary includes to detangle these classes from other classes that have layering violati… (Closed)

Created:
7 years, 2 months ago by atreat
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Remove unnecessary includes to detangle these classes from other classes that have layering violations in preparation to move them to Source/platform BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159154

Patch Set 1 #

Patch Set 2 : Rebase to apply cleanly #

Patch Set 3 : Rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/platform/ScrollView.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/mock/ScrollbarThemeMock.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
atreat
Get includes out of the way that are unnecessary and are entangled in layering violations
7 years, 2 months ago (2013-10-08 15:21:22 UTC) #1
abarth-chromium
lgtm
7 years, 2 months ago (2013-10-08 16:20:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/26432006/1
7 years, 2 months ago (2013-10-08 16:20:12 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/platform/ScrollView.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-08 16:20:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/26432006/6001
7 years, 2 months ago (2013-10-08 18:11:53 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/platform/ScrollView.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-08 18:11:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/26432006/10001
7 years, 2 months ago (2013-10-08 18:13:52 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-08 20:42:17 UTC) #8
Message was sent while issue was closed.
Change committed as 159154

Powered by Google App Engine
This is Rietveld 408576698