Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26432002: Fix unit_tests build on Fedora 20. (Closed)

Created:
7 years, 2 months ago by pwnall-personal
Modified:
7 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix unit_tests build on Fedora 20. BUG=305074 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227701

Patch Set 1 #

Patch Set 2 : Re-uploading. The upload script failed during the upload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/extensions/api/web_request/web_request_time_tracker_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_pref_value_map_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
pwnall-personal
Tried building on a Fedora 20 machine, and it turns out that its gcc is ...
7 years, 2 months ago (2013-10-08 04:19:56 UTC) #1
mtomasz
lgtm, but I'm not an owner. Please wait for @mpcomplete's review.
7 years, 2 months ago (2013-10-08 05:02:24 UTC) #2
pwnall-personal
On 2013/10/08 05:02:24, mtomasz wrote: > lgtm, but I'm not an owner. Please wait for ...
7 years, 2 months ago (2013-10-08 05:03:43 UTC) #3
asargent_no_longer_on_chrome
lgtm
7 years, 2 months ago (2013-10-08 18:24:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/costan@gmail.com/26432002/2001
7 years, 2 months ago (2013-10-08 18:28:45 UTC) #5
Matt Perry
lgtm
7 years, 2 months ago (2013-10-08 19:04:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/costan@gmail.com/26432002/2001
7 years, 2 months ago (2013-10-09 02:27:02 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 08:24:18 UTC) #8
Message was sent while issue was closed. 
Change committed as 227701

Powered by Google App Engine
This is Rietveld 408576698