Deprecate the use of `Function` as a class.

Deprecate the use of `Function` as a class.

Shows a hint when `Function` is used:
- as a class name,
- in an extends clause,
- in a with clause.

The `Function` may or may not point to the core's `Function`. All uses of `Function` in these contexts are deprecated.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/4e6e72b0b0bc1558ea0ba695363c6dc8bf9433f5

Reverted: https://github.com/dart-lang/sdk/commit/3f871ae76f5269b50e531c61038727a074301990
Committed: https://github.com/dart-lang/sdk/commit/9a0ccfc0926a2df519c123b9d2792ee4d6674278

[floitsch, 2017-01-19 18:02:24]

floitsch@google.com changed reviewers:
+ brianwilkerson@google.com

[floitsch, 2017-01-19 18:02:25]

This CL works under the assumption, that we will make `Function` a built-in
identifier (similar to `dynamic`).

We could be less restrictive and simply disallow the creation of `Function`
classes. Conceptually that shouldn't change much for the CL, though.

I still need to check with the language team, if this approach is what we want.

[Brian Wilkerson, 2017-01-19 18:16:05]

lgtm

https://codereview.chromium.org/2643073002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/2643073002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:2963:
HintCode.DEPRECATED_EXTENDS_FUNCTION, extendsClause);
'extendsClause' --> 'extendsClause.superclass'

https://codereview.chromium.org/2643073002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/hint_code_test.dart (right):

https://codereview.chromium.org/2643073002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/hint_code_test.dart:1006:
test_deprecatedFunction_mixin() async {
Perhaps split this into two tests (one with and one without the local
declaration of 'Function')?

[floitsch, 2017-01-19 18:22:49]

https://codereview.chromium.org/2643073002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/2643073002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:2963:
HintCode.DEPRECATED_EXTENDS_FUNCTION, extendsClause);
On 2017/01/19 18:16:05, Brian Wilkerson wrote:
> 'extendsClause' --> 'extendsClause.superclass'

Done.

https://codereview.chromium.org/2643073002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/hint_code_test.dart (right):

https://codereview.chromium.org/2643073002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/hint_code_test.dart:1006:
test_deprecatedFunction_mixin() async {
On 2017/01/19 18:16:05, Brian Wilkerson wrote:
> Perhaps split this into two tests (one with and one without the local
> declaration of 'Function')?

Done.

[floitsch, 2017-01-23 14:43:32]

Removed the 'implements Function` part.

It's used quite frequently and, if necessary, we can deprecate it at a later
point.

[floitsch, 2017-01-23 15:39:10]

Description was changed from

==========
Deprecate the use of `Function` as a class.

Shows a hint when `Function` is used:
- as a class name,
- in an extends clause,
- in an implements clause,
- in a with clause.

The `Function` may or may not point to the core's `Function`. All uses of
`Function` in these contexts are deprecated.
==========

to

==========
Deprecate the use of `Function` as a class.

Shows a hint when `Function` is used:
- as a class name,
- in an extends clause,
- in an implements clause,
- in a with clause.

The `Function` may or may not point to the core's `Function`. All uses of
`Function` in these contexts are deprecated.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4e6e72b0b0bc1558ea0ba695363c6dc8bf9433f5
==========

[floitsch, 2017-01-23 15:39:11]

Committed patchset #4 (id:60001) manually as
4e6e72b0b0bc1558ea0ba695363c6dc8bf9433f5 (presubmit successful).

[floitsch, 2017-01-23 16:10:39]

Description was changed from

==========
Deprecate the use of `Function` as a class.

Shows a hint when `Function` is used:
- as a class name,
- in an extends clause,
- in an implements clause,
- in a with clause.

The `Function` may or may not point to the core's `Function`. All uses of
`Function` in these contexts are deprecated.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4e6e72b0b0bc1558ea0ba695363c6dc8bf9433f5
==========

to

==========
Deprecate the use of `Function` as a class.

Shows a hint when `Function` is used:
- as a class name,
- in an extends clause,
- in a with clause.

The `Function` may or may not point to the core's `Function`. All uses of
`Function` in these contexts are deprecated.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4e6e72b0b0bc1558ea0ba695363c6dc8bf9433f5

Reverted:
https://github.com/dart-lang/sdk/commit/3f871ae76f5269b50e531c61038727a074301990
==========

[floitsch, 2017-01-23 16:22:24]

Forgot to run the tests in host-checked mode.

Ready to reapply this CL. PTAL if you want.

[Brian Wilkerson, 2017-01-23 16:25:39]

lgtm

[floitsch, 2017-01-23 16:34:14]

Description was changed from

==========
Deprecate the use of `Function` as a class.

Shows a hint when `Function` is used:
- as a class name,
- in an extends clause,
- in a with clause.

The `Function` may or may not point to the core's `Function`. All uses of
`Function` in these contexts are deprecated.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4e6e72b0b0bc1558ea0ba695363c6dc8bf9433f5

Reverted:
https://github.com/dart-lang/sdk/commit/3f871ae76f5269b50e531c61038727a074301990
==========

to

==========
Deprecate the use of `Function` as a class.

Shows a hint when `Function` is used:
- as a class name,
- in an extends clause,
- in a with clause.

The `Function` may or may not point to the core's `Function`. All uses of
`Function` in these contexts are deprecated.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4e6e72b0b0bc1558ea0ba695363c6dc8bf9433f5

Reverted:
https://github.com/dart-lang/sdk/commit/3f871ae76f5269b50e531c61038727a074301990
Committed:
https://github.com/dart-lang/sdk/commit/9a0ccfc0926a2df519c123b9d2792ee4d6674278
==========

[floitsch, 2017-01-23 16:34:16]

Committed patchset #6 (id:100001) manually as
9a0ccfc0926a2df519c123b9d2792ee4d6674278 (presubmit successful).