third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp - Issue 2643063002: Refactor Blink's ServiceConnector and add ability to mock in layout tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp

Issue 2643063002: Refactor Blink's ServiceConnector and add ability to mock in layout tests (Closed)

Patch Set: Fix build Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/resources/mojo-helpers.js ('k') | third_party/WebKit/Source/modules/time_zone_monitor/TimeZoneMonitorClient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp

diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp

index 4e6defe840e334589ef3a8bebdcbe575a094c49b..6e9e62c1c63249408912446811293c804380e54a 100644

--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp

+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp

@@ -4,7 +4,7 @@

#include "modules/screen_orientation/ScreenOrientationDispatcher.h"

-#include "platform/ServiceConnector.h"

+#include "public/platform/Connector.h"

#include "public/platform/Platform.h"

#include "services/device/public/interfaces/constants.mojom-blink.h"

@@ -29,7 +29,7 @@ DEFINE_TRACE(ScreenOrientationDispatcher) {

void ScreenOrientationDispatcher::startListening() {

DCHECK(!m_listener);

- ServiceConnector::instance().connectToInterface(

+ Platform::current()->connector()->bindInterface(

device::mojom::blink::kServiceName, mojo::MakeRequest(&m_listener));

m_listener->Start();

}