Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: third_party/WebKit/Source/core/editing/FrameCaret.cpp

Issue 2643033005: Make FrameCaret to utilize SynchronousMutationObserver (Closed)
Patch Set: 2017-01-20T14:30:09 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameCaret.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameCaret.cpp b/third_party/WebKit/Source/core/editing/FrameCaret.cpp
index b74c2fc6dc466a03d8003af7389cc2fa8a88d8ff..b8b958e85dd74cb1e3d421836fca481eed5a240e 100644
--- a/third_party/WebKit/Source/core/editing/FrameCaret.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameCaret.cpp
@@ -66,6 +66,11 @@ DEFINE_TRACE(FrameCaret) {
visitor->trace(m_frame);
visitor->trace(m_previousCaretNode);
visitor->trace(m_previousCaretAnchorNode);
+ SynchronousMutationObserver::trace(visitor);
+}
+
+void FrameCaret::documentAttached(Document* document) {
+ setContext(document);
}
const PositionWithAffinity FrameCaret::caretPosition() const {
@@ -302,7 +307,7 @@ void FrameCaret::nodeWillBeRemoved(Node& node) {
m_previousCaretVisibility = CaretVisibility::Hidden;
}
-void FrameCaret::documentDetached() {
+void FrameCaret::contextDestroyed(Document*) {
m_caretBlinkTimer.stop();
m_previousCaretNode.clear();
m_previousCaretAnchorNode.clear();

Powered by Google App Engine
This is Rietveld 408576698