Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2643033003: Clean up hacky handling of "dart:" URIs in incremental resolved AST generator. (Closed)

Created:
3 years, 11 months ago by Paul Berry
Modified:
3 years, 11 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean up hacky handling of "dart:" URIs in incremental resolved AST generator. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/7bfc3ced58b355f27b7454d8828a014744d2e234

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -23 lines) Patch
M pkg/front_end/lib/src/base/file_repository.dart View 3 chunks +20 lines, -15 lines 0 comments Download
M pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart View 3 chunks +9 lines, -8 lines 0 comments Download
M pkg/front_end/test/src/base/file_repository_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 11 months ago (2017-01-19 22:18:56 UTC) #2
danrubel
LGTM
3 years, 11 months ago (2017-01-20 16:42:51 UTC) #3
Paul Berry
3 years, 11 months ago (2017-01-20 16:54:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7bfc3ced58b355f27b7454d8828a014744d2e234 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698