Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 264303009: Add elfutils via DEPS. (Closed)

Created:
6 years, 7 months ago by simonb (inactive)
Modified:
6 years, 7 months ago
Reviewers:
simonb1, Daniel Berlin, cmp, bulach, mkosiba (inactive), kenrb, open-source-third-party-reviews
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add elfutils via DEPS. Add third_party/elfutils, at release 0.158. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271400

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update for review feedback. #

Patch Set 3 : Review feedback updates. #

Patch Set 4 : Add known_issues.py fix for webview_licenses.py complaint. #

Patch Set 5 : Add README.security file. #

Patch Set 6 : Merge 'master' into review branch. #

Patch Set 7 : Merge 'master' into review branch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M .gitignore View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M android_webview/tools/known_issues.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/elfutils/OWNERS View 1 2 1 chunk +1 line, -1 line 0 comments Download
A third_party/elfutils/README.chromium View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/elfutils/README.security View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
bulach
https://codereview.chromium.org/264303009/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/264303009/diff/1/DEPS#newcode523 DEPS:523: "src/third_party/elfutils": nit: I think you want under a further ...
6 years, 7 months ago (2014-05-08 18:25:09 UTC) #1
simonb (inactive)
https://codereview.chromium.org/264303009/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/264303009/diff/1/DEPS#newcode523 DEPS:523: "src/third_party/elfutils": On 2014/05/08 18:25:09, bulach wrote: > nit: I ...
6 years, 7 months ago (2014-05-09 11:16:32 UTC) #2
bulach
thanks simon! sorry, I just remembered: I think we also need to add: /third_party/elfutils/src to ...
6 years, 7 months ago (2014-05-09 11:27:11 UTC) #3
simonb (inactive)
On 2014/05/09 11:27:11, bulach wrote: > thanks simon! sorry, I just remembered: I think we ...
6 years, 7 months ago (2014-05-09 11:49:04 UTC) #4
bulach
lgtm, thanks! I put through the try bots to validate. once we hear back form ...
6 years, 7 months ago (2014-05-09 12:59:44 UTC) #5
Daniel Berlin
Fine for open-source-third-party-reviews
6 years, 7 months ago (2014-05-09 14:33:25 UTC) #6
simonb (inactive)
6 years, 7 months ago (2014-05-09 15:03:56 UTC) #7
simonb (inactive)
On 2014/05/09 15:03:56, simonb wrote: Ping: security@chromium.org?
6 years, 7 months ago (2014-05-14 17:57:57 UTC) #8
kenrb
security lgtm
6 years, 7 months ago (2014-05-16 15:25:45 UTC) #9
simonb1
The CQ bit was checked by simonb@google.com
6 years, 7 months ago (2014-05-16 17:21:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/264303009/100001
6 years, 7 months ago (2014-05-16 17:21:56 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 20:31:54 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 20:41:06 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68215)
6 years, 7 months ago (2014-05-16 20:41:06 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 05:55:31 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-17 06:02:32 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68251)
6 years, 7 months ago (2014-05-17 06:02:33 UTC) #17
simonb1
android_webview owners, please add required lgtm to resolve this. Thx. ** Presubmit ERRORS ** Missing ...
6 years, 7 months ago (2014-05-19 10:24:49 UTC) #18
simonb1
6 years, 7 months ago (2014-05-19 13:06:33 UTC) #19
mkosiba (inactive)
lgtm
6 years, 7 months ago (2014-05-19 13:36:27 UTC) #20
simonb1
The CQ bit was checked by simonb@google.com
6 years, 7 months ago (2014-05-19 13:49:26 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/264303009/110001
6 years, 7 months ago (2014-05-19 13:49:35 UTC) #22
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 16:49:40 UTC) #23
Message was sent while issue was closed.
Change committed as 271400

Powered by Google App Engine
This is Rietveld 408576698