chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 264303006: Support full-screen and single-profile avatar bubbles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 264303006: Support full-screen and single-profile avatar bubbles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Never enable the command on ChromeOS. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index e503c925b2c54ea110db868a0bfd418a811adcd6..f9ee6e71262417d5fbc2d13988b2a1fc14920060 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -706,7 +706,10 @@ void BrowserWindowCocoa::ShowAvatarBubble(WebContents* web_contents,

void BrowserWindowCocoa::ShowAvatarBubbleFromAvatarButton(

AvatarBubbleMode mode) {

AvatarBaseController* controller = [controller_ avatarButtonController];

- [controller showAvatarBubble:[controller buttonView] withMode:mode];

+ NSView* anchor = [controller buttonView];

+ if ([anchor isHiddenOrHasHiddenAncestor])

+ anchor = [[controller_ toolbarController] wrenchButton];

+ [controller showAvatarBubble:anchor withMode:mode];

}

void BrowserWindowCocoa::ShowPasswordGenerationBubble(