Support full-screen and single-profile avatar bubbles.

chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/profiles/avatar_menu_bubble_view.h"
 
 #include <algorithm>
 
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 473 matching lines @@
 // static
 void AvatarMenuBubbleView::ShowBubble(
     views::View* anchor_view,
     views::BubbleBorder::Arrow arrow,
     views::BubbleBorder::BubbleAlignment border_alignment,
     const gfx::Rect& anchor_rect,
     Browser* browser) {
   if (IsShowing())
     return;
 
-  DCHECK(chrome::IsCommandEnabled(browser, IDC_SHOW_AVATAR_MENU));

[Peter Kasting, 2014/05/07 20:58:44]

So it actually makes sense to show the menu in the single profile/fullscreen
cases?  If so why don't we also enable the command at those times?

[msw, 2014/05/07 21:31:07]

When enabling the command also enables the Ctrl+Shift+M accelerator (eye roll)
to show the avatar menu from the avatar icon. That icon doesn't exist in the
single-user or fullscreen cases. It seems wrong to additionally enable the
command when the apps page is active and then conditionally anchor the menu to
the apps page link, but your advice is welcome.

[Peter Kasting, 2014/05/07 21:33:36]

Consider:

F11, ctrl-D

This bookmarks the current page and pops up the bookmark bubble even though the
star is invisible.

If we're going to have a shortcut for the avatar menu, and the menu will get
shown onscreen, and the menu can already be triggered without the icon visible
anyway, I say let's just do like with the star and enable the command at those
times.  People goofy enough to know and use this keyboard shortcut will probably
be happy and no one else will notice.

[msw, 2014/05/07 21:47:43]

That's reasonable, but is it worth adding this functionality to the avatar
bubble when there are efforts underway to replace it altogether?

[Peter Kasting, 2014/05/07 21:50:05]

Are we really adding functionality?  I thought all the code already existed and
worked in all these cases, and the only issue is that you'd be making a one-line
change or so to not disable the command as frequently.

[msw, 2014/05/07 23:19:18]

The latest patch set adds support for the command in fullscreen. The only new
real functionality is hiding the arrow for bubbles shown while the avatar icon
is hidden in fullscreen. The command is still disabled when there is only a
single profile, so this DCHECK is still incorrect. Thoughts?

   avatar_bubble_ = new AvatarMenuBubbleView(
       anchor_view, arrow, anchor_rect, browser);
   views::BubbleDelegateView::CreateBubble(avatar_bubble_);
   avatar_bubble_->set_close_on_deactivate(close_on_deactivate_for_testing_);
   avatar_bubble_->SetBackgroundColors();
   avatar_bubble_->SetAlignment(border_alignment);
   avatar_bubble_->GetWidget()->Show();
 }
 
 // static
@@ skipping 296 matching lines @@
   Layout();
   if (GetBubbleFrameView())
     SizeToContents();
 }
 
 void AvatarMenuBubbleView::SetBackgroundColors() {
   for (size_t i = 0; i < item_views_.size(); ++i) {
     item_views_[i]->OnHighlightStateChanged();
   }
 }