Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1793)

Unified Diff: content/renderer/pepper/resource_converter.h

Issue 264303002: PPAPI: Implement synchronous postMessage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: defer some changes Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/resource_converter.h
diff --git a/content/renderer/pepper/resource_converter.h b/content/renderer/pepper/resource_converter.h
index 5b46adf4c533b1866a7a4e07eca00a1d18845ca6..830a96cb35eec79939a2d75108e10ff7ca23e5ff 100644
--- a/content/renderer/pepper/resource_converter.h
+++ b/content/renderer/pepper/resource_converter.h
@@ -34,9 +34,11 @@ class CONTENT_EXPORT ResourceConverter {
public:
virtual ~ResourceConverter();
- // Flush() must be called before any vars created by the ResourceConverter
- // are valid. It handles creating any resource hosts that need to be created.
+ // Flush() or FlushSync must be called before any vars created by the
raymes 2014/06/10 04:50:47 nit for consistency: FlushSync()
dmichael (off chromium) 2014/06/13 22:01:26 Done. Although I *may* not need it in the short te
+ // ResourceConverter are valid. They handle creating any resource hosts that
+ // need to be created.
virtual void Flush(const base::Callback<void(bool)>& callback) = 0;
+ virtual bool FlushSync() = 0;
// Attempts to convert a V8 object to a PP_Var with type PP_VARTYPE_RESOURCE.
// On success, writes the resulting var to |result|, sets |was_resource| to
@@ -62,6 +64,7 @@ class ResourceConverterImpl : public ResourceConverter {
// ResourceConverter overrides.
virtual void Flush(const base::Callback<void(bool)>& callback) OVERRIDE;
+ virtual bool FlushSync() OVERRIDE;
virtual bool FromV8Value(v8::Handle<v8::Object> val,
v8::Handle<v8::Context> context,
PP_Var* result,

Powered by Google App Engine
This is Rietveld 408576698