Speed up sanitizing headers received from HTTP proxies.

net/http/http_response_headers_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_response_headers.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <iostream>
 #include <limits>
 #include <memory>
+#include <unordered_set>
 
 #include "base/pickle.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "net/http/http_byte_range.h"
 #include "net/log/net_log_capture_mode.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
@@ skipping 1733 matching lines @@
     "HTTP/1.1 200 OK\n"
     "connection: keep-alive\n"
     "Cache-control: max-age=10000\n"
   },
 };
 
 INSTANTIATE_TEST_CASE_P(HttpResponseHeaders,
                         RemoveHeaderTest,
                         testing::ValuesIn(remove_header_tests));
 
+struct RemoveHeadersTestData {
+  const char* orig_headers;
+  const char* to_remove[2];
+  const char* expected_headers;
+};
+
+class RemoveHeadersTest
+    : public HttpResponseHeadersTest,
+      public ::testing::WithParamInterface<RemoveHeadersTestData> {};
+
+TEST_P(RemoveHeadersTest, RemoveHeaders) {
+  const RemoveHeadersTestData test = GetParam();
+
+  std::string orig_headers(test.orig_headers);
+  HeadersToRaw(&orig_headers);
+  scoped_refptr<HttpResponseHeaders> parsed(
+      new HttpResponseHeaders(orig_headers));
+
+  std::unordered_set<std::string> to_remove;
+  for (const auto& header : test.to_remove) {
+    if (header)
+      to_remove.insert(header);
+  }
+  parsed->RemoveHeaders(to_remove);
+
+  std::string resulting_headers;
+  parsed->GetNormalizedHeaders(&resulting_headers);
+  EXPECT_EQ(std::string(test.expected_headers), resulting_headers);
+}
+
+const RemoveHeadersTestData remove_headers_tests[] = {
+    {"HTTP/1.1 200 OK\n"
+     "connection: keep-alive\n"
+     "Cache-control: max-age=10000\n"
+     "Content-Length: 450\n",
+
+     {"Content-Length", "CACHE-control"},
+
+     "HTTP/1.1 200 OK\n"
+     "connection: keep-alive\n"},
+
+    {"HTTP/1.1 200 OK\n"
+     "connection: keep-alive\n"
+     "Content-Length: 450\n",
+
+     {"foo", "bar"},
+
+     "HTTP/1.1 200 OK\n"
+     "connection: keep-alive\n"
+     "Content-Length: 450\n"},
+
+    {"HTTP/1.1 404 Kinda not OK\n"
+     "connection: keep-alive  \n",
+
+     {},
+
+     "HTTP/1.1 404 Kinda not OK\n"
+     "connection: keep-alive\n"},
+};
+
+INSTANTIATE_TEST_CASE_P(HttpResponseHeaders,
+                        RemoveHeadersTest,
+                        testing::ValuesIn(remove_headers_tests));
+
 struct RemoveIndividualHeaderTestData {
   const char* orig_headers;
   const char* to_remove_name;
   const char* to_remove_value;
   const char* expected_headers;
 };
 
 class RemoveIndividualHeaderTest
     : public HttpResponseHeadersTest,
       public ::testing::WithParamInterface<RemoveIndividualHeaderTestData> {
@@ skipping 355 matching lines @@
 TEST_F(HttpResponseHeadersCacheControlTest,
        FirstStaleWhileRevalidateValueUsed) {
   InitializeHeadersWithCacheControl(
       "stale-while-revalidate=1,stale-while-revalidate=7200");
   EXPECT_EQ(TimeDelta::FromSeconds(1), GetStaleWhileRevalidateValue());
 }
 
 }  // namespace
 
 }  // namespace net