chrome/common/extensions/api/file_system_provider.idl - Issue 2643013002: Don't crash browser process when OK passed as error code in FSP API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/file_system_provider.idl

Issue 2643013002: Don't crash browser process when OK passed as error code in FSP API. (Closed)

Patch Set: Don't crash browser process when OK passed as error code in FSP API. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/api/file_system_provider.idl

diff --git a/chrome/common/extensions/api/file_system_provider.idl b/chrome/common/extensions/api/file_system_provider.idl

index b18d46afc936e6e3fc1204228c615610b639435f..b4c9f2e6aa8a7de817ea32988899aede81c8eb3f 100644

--- a/chrome/common/extensions/api/file_system_provider.idl

+++ b/chrome/common/extensions/api/file_system_provider.idl

@@ -518,6 +518,7 @@ namespace fileSystemProvider {

[nocompile] callback ProviderSuccessCallback = void();

// Callback to be called by the providing extension in case of an error.

+ // Any error code is allowed except <code>OK</code>.

[nocompile] callback ProviderErrorCallback = void(ProviderError error);

// Success callback for the $(ref:onGetMetadataRequested) event.