Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: PRESUBMIT.py

Issue 2642973006: Include AIDL files in the presubmit check for IPC security. (Closed)
Patch Set: Move `using` statements. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ash/public/interfaces/OWNERS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 1437 matching lines...) Expand 10 before | Expand all | Expand 10 after
1448 input_api, output_api, 'tools/android/checkstyle/chromium-style-5.0.xml', 1448 input_api, output_api, 'tools/android/checkstyle/chromium-style-5.0.xml',
1449 black_list=_EXCLUDED_PATHS + input_api.DEFAULT_BLACK_LIST) 1449 black_list=_EXCLUDED_PATHS + input_api.DEFAULT_BLACK_LIST)
1450 1450
1451 1451
1452 def _CheckIpcOwners(input_api, output_api): 1452 def _CheckIpcOwners(input_api, output_api):
1453 """Checks that affected files involving IPC have an IPC OWNERS rule. 1453 """Checks that affected files involving IPC have an IPC OWNERS rule.
1454 1454
1455 Whether or not a file affects IPC is determined by a simple whitelist of 1455 Whether or not a file affects IPC is determined by a simple whitelist of
1456 filename patterns.""" 1456 filename patterns."""
1457 file_patterns = [ 1457 file_patterns = [
1458 # Legacy IPC:
1458 '*_messages.cc', 1459 '*_messages.cc',
1459 '*_messages*.h', 1460 '*_messages*.h',
1460 '*_param_traits*.*', 1461 '*_param_traits*.*',
1462 # Mojo IPC:
1461 '*.mojom', 1463 '*.mojom',
1462 '*_struct_traits*.*', 1464 '*_struct_traits*.*',
1463 '*_type_converter*.*', 1465 '*_type_converter*.*',
1464 # Blink uses a different file naming convention 1466 '*.typemap',
1467 # Android native IPC:
1468 '*.aidl',
1469 # Blink uses a different file naming convention:
1470 '*EnumTraits*.*',
1465 '*StructTraits*.*', 1471 '*StructTraits*.*',
1466 '*TypeConverter*.*', 1472 '*TypeConverter*.*',
1467 ] 1473 ]
1468 1474
1469 # These third_party directories do not contain IPCs, but contain files 1475 # These third_party directories do not contain IPCs, but contain files
1470 # matching the above patterns, which trigger false positives. 1476 # matching the above patterns, which trigger false positives.
1471 exclude_paths = [ 1477 exclude_paths = [
1472 'third_party/crashpad/*', 1478 'third_party/crashpad/*',
1473 ] 1479 ]
1474 1480
(...skipping 886 matching lines...) Expand 10 before | Expand all | Expand 10 after
2361 results.extend(input_api.canned_checks.CheckTreeIsOpen( 2367 results.extend(input_api.canned_checks.CheckTreeIsOpen(
2362 input_api, 2368 input_api,
2363 output_api, 2369 output_api,
2364 json_url='http://chromium-status.appspot.com/current?format=json')) 2370 json_url='http://chromium-status.appspot.com/current?format=json'))
2365 2371
2366 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2372 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2367 input_api, output_api)) 2373 input_api, output_api))
2368 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2374 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2369 input_api, output_api)) 2375 input_api, output_api))
2370 return results 2376 return results
OLDNEW
« no previous file with comments | « no previous file | ash/public/interfaces/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698